linux-kernel - Re: [PATCH net-next v5] net: phy: add driver for MaxLinear MxL86110 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK+owoiyB2mG+Q+pfEOkDc7jUj=zngiup32F1f4C0Q8RzTCBEQ@mail.gmail.com>
Date: Wed, 21 May 2025 23:25:56 +0200
From: Stefano Radaelli <stefano.radaelli21@...il.com>
To: ALOK TIWARI <alok.a.tiwari@...cle.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, 
	Russell King <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Xu Liang <lxu@...linear.com>
Subject: Re: [PATCH net-next v5] net: phy: add driver for MaxLinear MxL86110 PHY

Thank you Alok,

I will make those fixes in the next release v6.

Best Regards,

Stefano

Il giorno mer 21 mag 2025 alle ore 15:15 ALOK TIWARI
<alok.a.tiwari@...cle.com> ha scritto:
>
>
>
> On 21-05-2025 17:04, stefano.radaelli21@...il.com wrote:
> > +/**
> > + * mxl86110_enable_led_activity_blink - Enable LEDs activity blink on PHY
> > + * @phydev: Pointer to the PHY device structure
> > + *
> > + * Configure all PHY LEDs to blink on traffic activity regardless of their
> > + * ON or OFF state. This behavior allows each LED to serve as a pure activity
> > + * indicator, independently of its use as a link status indicator.
> > + *
>
> "regardless of whether they are ON or OFF"
>
> > + * By default, each LED blinks only when it is also in the ON state.
> > + * This function modifies the appropriate registers (LABx fields)
> > + * to enable blinking even when the LEDs are OFF, to allow the LED to be used
> > + * as a traffic indicator without requiring it to also serve
> > + * as a link status LED.
> > + *
> > + * Note: Any further LED customization can be performed via the
> > + * /sys/class/led interface; the functions led_hw_is_supported,
>
> /sys/class/led -> /sys/class/leds (it is leds in sysfs)
>
> > + * led_hw_control_get, and led_hw_control_set are used
> > + * to support this mechanism.
> > + *
> > + * This function assumes the caller already holds the MDIO bus lock
> > + * or otherwise has exclusive access to the PHY.
> > + *
> > + * Return: 0 on success or a negative errno code on failure.
> > + */
> > +static int mxl86110_enable_led_activity_blink(struct phy_device *phydev)
> > +{
> > +     int i, ret = 0;
> > +
> > +     for (i = 0; i < MXL86110_MAX_LEDS; i++) {
> > +             ret = __mxl86110_modify_extended_reg(phydev,
> > +                                                  MXL86110_LED0_CFG_REG + i,
> > +                                                  0,
> > +                                                  MXL86110_LEDX_CFG_BLINK);
> > +             if (ret < 0)
> > +                     break;
> > +     }
> > +
> > +     return ret;
> > +};
>
> remove ;
>
>
> Thanks,
> Alok
>