linux-kernel - Re: [PATCH] dmaengine: idxd: Fix warning for deadcode.deadstore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <502b82d9-7343-46b2-a820-c7f47f12de10@intel.com>
Date: Wed, 21 May 2025 16:13:49 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
 vinicius.gomes@...el.com, fenghuay@...dia.com, vkoul@...nel.org
Cc: dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: Fix warning for deadcode.deadstore



On 5/21/25 4:13 PM, Anil S Keshavamurthy wrote:
> Deletes the  second initialization as the value stored to 'dev' during
> its initialization (struct device *dev = &idxd->pdev->dev;) is
> sufficient.
> 
> ../drivers/dma/idxd/init.c:988:17: warning: Value stored to 'dev' during
> its initialization is never read [deadcode.DeadStores]
>   988 |         struct device *dev = &idxd->pdev->dev;
>       |                        ^~~   ~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>

Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> ---
>  drivers/dma/idxd/init.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
> index fca1d2924999..b7664136fc67 100644
> --- a/drivers/dma/idxd/init.c
> +++ b/drivers/dma/idxd/init.c
> @@ -989,7 +989,6 @@ static void idxd_reset_prepare(struct pci_dev *pdev)
>  	const char *idxd_name;
>  	int rc;
>  
> -	dev = &idxd->pdev->dev;
>  	idxd_name = dev_name(idxd_confdev(idxd));
>  
>  	struct idxd_saved_states *idxd_saved __free(kfree) =