linux-kernel - Re: [PATCH] crypto: qat - add missing header inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aC1c7+PQZN++5mgf@gcabiddu-mobl.ger.corp.intel.com>
Date: Wed, 21 May 2025 05:56:15 +0100
From: "Cabiddu, Giovanni" <giovanni.cabiddu@...el.com>
To: Arnd Bergmann <arnd@...nel.org>
CC: Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller"
	<davem@...emloft.net>, Karthikeyan Gopal <karthikeyan.gopal@...el.com>,
	Laurent M Coquerel <laurent.m.coquerel@...el.com>, Suman Kumar Chakraborty
	<suman.kumar.chakraborty@...el.com>, Arnd Bergmann <arnd@...db.de>, "George
 Abraham P" <george.abraham.p@...el.com>, <qat-linux@...el.com>,
	<linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: qat - add missing header inclusion

On Tue, May 20, 2025 at 06:11:36PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Without this header, building the new driver fails with:
> 
> In file included from drivers/crypto/intel/qat/qat_common/adf_gen6_shared.c:7:
> drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h: In function 'adf_gen4_init_pf_pfvf_ops':
> drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h:13:34: error: 'adf_pfvf_comms_disabled' undeclared (first use in this function)
>    13 |         pfvf_ops->enable_comms = adf_pfvf_comms_disabled;
>       |                                  ^~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Thanks Arnd. This occurs with CONFIG_PCI_IOV not set. Can this be added
to the commit message?

> ---
>  drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h | 1 +
>  drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h b/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
> index a716545a764c..9efee0053f3a 100644
> --- a/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
> +++ b/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
> @@ -4,6 +4,7 @@
>  #define ADF_GEN2_PFVF_H
>  
>  #include <linux/types.h>
> +#include "adf_common_drv.h"
>  #include "adf_accel_devices.h"
NIT. Can this be in alphabetical order?

>  
>  #define ADF_GEN2_ERRSOU3 (0x3A000 + 0x0C)
> diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h b/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h
> index 17d1b774d4a8..2c8708117f70 100644
> --- a/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h
> +++ b/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h
> @@ -4,6 +4,7 @@
>  #define ADF_GEN4_PFVF_H
>  
>  #include "adf_accel_devices.h"
> +#include "adf_common_drv.h"
>  
>  #ifdef CONFIG_PCI_IOV
>  void adf_gen4_init_pf_pfvf_ops(struct adf_pfvf_ops *pfvf_ops);

Thanks,

-- 
Giovanni