linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: qcs615: Enable camss for qcs615-adp-air

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9babbddc-5c45-4ef4-8fbc-0da64ce99a42@kernel.org>
Date: Wed, 21 May 2025 08:04:10 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
 Wenmeng Liu <quic_wenmliu@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, bryan.odonoghue@...aro.org, todor.too@...il.com,
 rfoss@...nel.org
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: qcs615: Enable camss for
 qcs615-adp-air

On 21/05/2025 07:52, Vladimir Zapolskiy wrote:
>> We can perform validation through the CSID TPG(Test Pattern Generator),
>> so I enabled CAMSS.
>>
> 
> Since this is just a test of CAMSS without any sensors/CSIPHY, then
> 
> 1. camss-csiphy-3ph-1-0.c changes from the series have never been tested
>     and added as dead code, it shall be removed from the series,
> 2. adding voltage regulators to the board dts is void and shall be removed.
> 
> Not to substitute but in addition to the above it's still doubtful, if just
> a hardware/driver test configuration deserves to be added into the dts.
No, it does not deserve to be added. It's useless code in upstream. They
just want to push whatever they had downstream and drop their patch count.

Best regards,
Krzysztof