linux-kernel - [tip: x86/core] x86/xen/msr: Fix uninitialized variable 'err'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174781060040.406.8154038959914617178.tip-bot2@tip-bot2>
Date: Wed, 21 May 2025 06:56:40 -0000
From: "tip-bot2 for Xin Li (Intel)" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: Dan Carpenter <dan.carpenter@...aro.org>, "Xin Li (Intel)" <xin@...or.com>,
 Ingo Molnar <mingo@...nel.org>, Juergen Gross <jgross@...e.com>,
 "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Subject: [tip: x86/core] x86/xen/msr: Fix uninitialized variable 'err'

The following commit has been merged into the x86/core branch of tip:

Commit-ID:     e95534e107d2e9e136aa4d7cbededb3827e80074
Gitweb:        https://git.kernel.org/tip/e95534e107d2e9e136aa4d7cbededb3827e80074
Author:        Xin Li (Intel) <xin@...or.com>
AuthorDate:    Sat, 17 May 2025 09:57:12 -07:00
Committer:     Ingo Molnar <mingo@...nel.org>
CommitterDate: Wed, 21 May 2025 08:44:31 +02:00

x86/xen/msr: Fix uninitialized variable 'err'

xen_read_msr_safe() currently passes an uninitialized argument 'err' to
xen_do_read_msr(). But as xen_do_read_msr() may not set the argument,
xen_read_msr_safe() could return err with an unpredictable value.

To ensure correctness, initialize err to 0 (representing success)
in xen_read_msr_safe().

Do the same in xen_read_msr(), even err is not used after being passed
to xen_do_read_msr().

Closes: https://lore.kernel.org/xen-devel/aBxNI_Q0-MhtBSZG@stanley.mountain/
Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
Signed-off-by: Xin Li (Intel) <xin@...or.com>
Signed-off-by: Ingo Molnar <mingo@...nel.org>
Reviewed-by: Juergen Gross <jgross@...e.com>
Cc: H. Peter Anvin <hpa@...or.com>
Link: https://lore.kernel.org/r/20250517165713.935384-1-xin@zytor.com
---
 arch/x86/xen/enlighten_pv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 7f9ded1..26bbaf4 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -1162,7 +1162,7 @@ static void xen_do_write_msr(u32 msr, u64 val, int *err)

 static int xen_read_msr_safe(u32 msr, u64 *val)
 {
-	int err;
+	int err = 0;

 	*val = xen_do_read_msr(msr, &err);
 	return err;
@@ -1179,7 +1179,7 @@ static int xen_write_msr_safe(u32 msr, u64 val)

 static u64 xen_read_msr(u32 msr)
 {
-	int err;
+	int err = 0;

 	return xen_do_read_msr(msr, xen_msr_safe ? &err : NULL);
 }