linux-kernel - Re: [PATCH] arm: Fix rustgcc unknown argument '-mno-fdpic'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nUFqM7mnpSGZF65n3Aak37KVVSa0d830o31EuZyh+OfA@mail.gmail.com>
Date: Wed, 21 May 2025 09:09:25 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Rudraksha Gupta <guptarud@...il.com>
Cc: torvalds@...ux-foundation.org, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Ben Wolsieffer <ben.wolsieffer@...ring.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Naresh Kamboju <naresh.kamboju@...aro.org>, 
	Christian Schrrefl <chrisi.schrefl@...il.com>, Russell King <rmk+kernel@...linux.org.uk>, 
	Ard Biesheuvel <ardb@...nel.org>, anders.roxell@...aro.org, arnd@...db.de, 
	dan.carpenter@...aro.org, laura.nao@...labora.com, 
	lkft-triage@...ts.linaro.org, regressions@...ts.linux.dev, 
	Nick Clifton <nickc@...hat.com>, Richard Earnshaw <richard.earnshaw@....com>, 
	Ramana Radhakrishnan <ramanara@...dia.com>, Linux Kernel Functional Testing <lkft@...aro.org>
Subject: Re: [PATCH] arm: Fix rustgcc unknown argument '-mno-fdpic'

On Wed, May 21, 2025 at 12:48 AM Rudraksha Gupta <guptarud@...il.com> wrote:
>
> Currently rust on arm fails to compile due to '-mno-fdpic'. This flag
> disables a GCC feature that we don't want for kernel builds, so let's
> skip it.
>
> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> Closes: https://lore.kernel.org/all/CA+G9fYvOanQBYXKSg7C6EU30k8sTRC0JRPJXYu7wWK51w38QUQ@mail.gmail.com/
>
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>
>
> Tested-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Signed-off-by: Naresh Kamboju <naresh.kamboju@...aro.org>

Thanks for the patch!

A few quick notes -- I hope these help to explain how it usually woks,
given what you said in the other thread:

  - Since you asked: in general, Linus does not take patches.
Normally, patches go through some relevant tree, and then then
eventually sent to Linus. In this case, the Rust tree would typically
be the one taking this patch. Please see the `MAINTAINERS` file.

  - You cannot generally send a patch in the name of someone else
unless they provided their Signed-off-by. Here, neither I nor Naresh
provided the Signed-off-by as far as I know. Please be careful with
that! Please read the DCO and the rest of the Submitting Patches file:
https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

  - Similarly, in general, you should be careful about adding tags
from someone else unless they provided them or there was an
understanding they meant to provide it (e.g. Tested-by). Please see
the "Tagging people requires permission" section in the same file:
https://docs.kernel.org/process/submitting-patches.html#tagging-people-requires-permission.

  - The chain of SoBs has a particular meaning. For instance, this
patch would mean (as written) that I wrote the patch, and that then
Naresh carried it, and then you carried it. And if I had written the
patch, then the Git author should have been me ("From:" would have
been added by Git). I guess you may have meant to indicate there were
several contributors -- that is typically done with e.g.
Co-developed-by or Suggested-by, depending on how they contributed.

  - There is some repeated text in the non-commit message part of the
email. Also, tags are written without empty lines between them.

  - Ideally, fixes for build errors contain the main part of the build
error message in the commit text so that it is easy to match it later
on.

What I would have suggested to do in this situation is to ping in the
other thread with a normal email (similar to the one you sent), asking
if Naresh or someone else was going to send it, and mention that
otherwise you are willing to do so (under yours or perhaps Naresh's
name).

I hope this helps!

Cheers,
Miguel