linux-kernel - Re: [PATCH] wifi: add sk_requests_wifi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoDtk2vNqiNWdG1hvo3jMNt0_fPffi5ts8LZWZzMDvsLXg@mail.gmail.com>
Date: Wed, 21 May 2025 15:23:47 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Bert Karwatzki <spasswolf@....de>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-next@...r.kernel.org, Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCH] wifi: add sk_requests_wifi_status()

On Wed, May 21, 2025 at 6:34 AM Bert Karwatzki <spasswolf@....de> wrote:
>
> Checking the SOCK_WIFI_STATUS flag bit in sk_flags, may give a wrong result
> since sk_flags are part of a union and the union is used otherwise. Add
> a sk_requests_wifi_status() which checks if sk is non-NULL, sk is a full socket
> and checks the flag bit.
>
> Fixes: 76a853f86c97 ("wifi: free SKBTX_WIFI_STATUS skb tx_flags flag")
> Idea-by: Johannes Berg <johannes.berg@...el.com>
> Signed-off-by: Bert Karwatzki <spasswolf@....de>

Since Johannes will modify it manually, so...
Reviewed-by: Jason Xing <kerneljasonxing@...il.com>

Thanks,
Jason