linux-kernel - RE: [PATCH] gpio: davinci: select GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8459CE5696113684FF076D12889EA@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Wed, 21 May 2025 07:27:41 +0000
From: Peng Fan <peng.fan@....com>
To: Bartosz Golaszewski <brgl@...ev.pl>, Linus Walleij
	<linus.walleij@...aro.org>
CC: "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Bartosz
 Golaszewski <bartosz.golaszewski@...aro.org>, kernel test robot
	<lkp@...el.com>
Subject: RE: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP

> Subject: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP
> 
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
> are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.
> 
> Fixes: 3f50bb3124d7 ("gpio: davinci: Make irq_chip immutable")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> lore.kernel.org%2Foe-kbuild-all%2F202505210606.PudPm5pC-
> lkp%40intel.com%2F&data=05%7C02%7Cpeng.fan%40nxp.com%7Ca0
> c5af787d854064539608dd983883ab%7C686ea1d3bc2b4c6fa92cd99c
> 5c301635%7C0%7C0%7C638834090666472921%7CUnknown%7CTW
> FpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAi
> OiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&
> sdata=DMwJeyC%2Bu4xmb1Ijuf6erLE3EVgprzEW%2FR4Gjo55zOs%3D
> &reserved=0
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

Acked-by: Peng Fan <peng.fan@....com>

> ---
> Another one signalled by the build bot. Peng: if you could go through
> the other patches you sent and verify their dependencies are satisfied,
> that would be awesome.

I tried all configs under arch/arm/configs/, no error with this patch applied.
I will give a check on other archs.

Thanks,
Peng

> 
>  drivers/gpio/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index
> bbc71cdde9ed6..5bc31b56b5157 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -253,6 +253,7 @@ config GPIO_DAVINCI
>  	tristate "TI Davinci/Keystone GPIO support"
>  	default y if ARCH_DAVINCI
>  	depends on ((ARM || ARM64) && (ARCH_DAVINCI ||
> ARCH_KEYSTONE || ARCH_K3)) || COMPILE_TEST
> +	select GPIOLIB_IRQCHIP
>  	help
>  	  Say yes here to enable GPIO support for TI Davinci/Keystone
> SoCs.
> 
> --
> 2.48.1