linux-kernel - Re: [PATCH v1 1/3] perf sample: Remove arch notion of sample parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f162665-be8d-4299-9442-a677e935999b@intel.com>
Date: Wed, 21 May 2025 11:13:54 +0300
From: Adrian Hunter <adrian.hunter@...el.com>
To: Ian Rogers <irogers@...gle.com>, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa
	<jolsa@...nel.org>, Kan Liang <kan.liang@...ux.intel.com>, James Clark
	<james.clark@...aro.org>, "Masami Hiramatsu (Google)" <mhiramat@...nel.org>,
	Ravi Bangoria <ravi.bangoria@....com>, Leo Yan <leo.yan@....com>, Yujie Liu
	<yujie.liu@...el.com>, Graham Woodward <graham.woodward@....com>, Howard Chu
	<howardchu95@...il.com>, Weilin Wang <weilin.wang@...el.com>, Dmitry Vyukov
	<dvyukov@...gle.com>, Andi Kleen <ak@...ux.intel.com>, Thomas Falcon
	<thomas.falcon@...el.com>, Matt Fleming <matt@...dmodwrite.com>, "Chun-Tse
 Shao" <ctshao@...gle.com>, Ben Gainey <ben.gainey@....com>, Song Liu
	<song@...nel.org>, <linux-kernel@...r.kernel.org>,
	<linux-perf-users@...r.kernel.org>
Subject: Re: [PATCH v1 1/3] perf sample: Remove arch notion of sample parsing

> diff --git a/tools/perf/include/perf/perf_dlfilter.h b/tools/perf/include/perf/perf_dlfilter.h
> index 16fc4568ac53..ec154fd937e7 100644
> --- a/tools/perf/include/perf/perf_dlfilter.h
> +++ b/tools/perf/include/perf/perf_dlfilter.h
> @@ -38,7 +38,7 @@ enum {
>  struct perf_dlfilter_sample {
>  	__u32 size; /* Size of this structure (for compatibility checking) */
>  	__u16 ins_lat;		/* Refer PERF_SAMPLE_WEIGHT_TYPE in <linux/perf_event.h> */
> -	__u16 p_stage_cyc;	/* Refer PERF_SAMPLE_WEIGHT_TYPE in <linux/perf_event.h> */
> +	__u16 p_stage_cyc_or_retire_lat; /* Refer PERF_SAMPLE_WEIGHT_TYPE in <linux/perf_event.h> */

Don't rename dlfilter API identifiers.  It will break dlfilter
compilation for anyone using the old identifier in their dlfilters.