linux-kernel - RE: [PATCH v2] r8152: Add wake up function for RTL8153

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8654b1d586ef48f081f7d3931cbc5ea9@realtek.com>
Date: Wed, 21 May 2025 08:39:55 +0000
From: Hayes Wang <hayeswang@...ltek.com>
To: Wentao Liang <vulab@...as.ac.cn>,
        "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org"
	<kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "ste3ls@...il.com" <ste3ls@...il.com>
CC: "dianders@...omium.org" <dianders@...omium.org>,
        "gmazyland@...il.com"
	<gmazyland@...il.com>,
        "linux-usb@...r.kernel.org"
	<linux-usb@...r.kernel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org"
	<stable@...r.kernel.org>
Subject: RE: [PATCH v2] r8152: Add wake up function for RTL8153

Wentao Liang <vulab@...as.ac.cn>
> Sent: Friday, May 16, 2025 9:36 AM
[...]
> In rtl8153_runtime_enable(), the runtime enable/disable logic for RTL8153
> devices was incomplete, missing r8153_queue_wake() to enable or disable
> the automatic wake-up function. A proper implementation can be found in
> rtl8156_runtime_enable().

r8153_queue_wake() is used to prevent the loss of wake-up events about linking
change during the process of runtime suspend. And, I don't think RTL8153A
supports it. Does this fix something?

Best Regards,
Hayes