| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <0d113a6c-712b-440a-8f45-e12fd498fa51@foss.st.com>
Date: Wed, 21 May 2025 10:55:33 +0200
From: Clement LE GOFFIC <clement.legoffic@...s.st.com>
To: Rob Herring <robh@...nel.org>
CC: Linus Walleij <linus.walleij@...aro.org>,
Krzysztof Kozlowski
<krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Maxime Coquelin
<mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Bartosz Golaszewski <brgl@...ev.pl>, <linux-kernel@...r.kernel.org>,
<linux-gpio@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-stm32@...md-mailman.stormreply.com>,
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 1/8] dt-bindings: pinctrl: stm32: Introduce HDP
On 5/20/25 21:37, Rob Herring wrote:
> On Tue, May 20, 2025 at 05:02:28PM +0200, Clément Le Goffic wrote:
>> 'HDP' stands for Hardware Debug Port, it is an hardware block in
>> STMicrolectronics' MPUs that let the user decide which internal SoC's
>> signal to observe.
>> It provides 8 ports and for each port there is up to 16 different
>> signals that can be output.
>> Signals are different for each MPU.
>>
>> Signed-off-by: Clément Le Goffic <clement.legoffic@...s.st.com>
>> ---
>> .../bindings/pinctrl/st,stm32-pinctrl-hdp.yaml | 188 +++++++++++++++++++++
>> 1 file changed, 188 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl-hdp.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl-hdp.yaml
>> new file mode 100644
>> index 000000000000..6251e9c16ced
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl-hdp.yaml
>> @@ -0,0 +1,188 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +# Copyright (C) STMicroelectronics 2025.
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pinctrl/st,stm32-pinctrl-hdp.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: STM32 Hardware Debug Port Mux/Config
>> +
>> +maintainers:
>> + - Clément LE GOFFIC <clement.legoffic@...s.st.com>
>> +
>> +description:
>> + STMicroelectronics's STM32 MPUs integrate a Hardware Debug Port (HDP).
>> + It allows to output internal signals on SoC's GPIO.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - st,stm32mp131-hdp
>> + - st,stm32mp151-hdp
>> + - st,stm32mp251-hdp
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> +patternProperties:
>> + "^hdp[0-7]-pins$":
>> + type: object
>> + $ref: pinmux-node.yaml#
>> + additionalProperties: false
>> +
>> + properties:
>> + pins:
>> + enum: [ HDP0, HDP1, HDP2, HDP3, HDP4, HDP5, HDP6, HDP7 ]
>
> This can be:
>
> pattern: '^HDP[0-7]$'
Hi Rob, thanks for pattern tips I didn't know it was possible
>
>
>> +
>> + function:
>> + maxItems: 1
>
> This is always 1 item, so just 'function: true' here.
Yes, I know I fought to make it work, and the maxItems was the only idea
that came out.
>
>> +
>> + required:
>> + - function
>> + - pins
>> +
>> +allOf:
>> + - $ref: pinctrl.yaml#
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: st,stm32mp131-hdp
>> + then:
>> + patternProperties:
>> + "^hdp[0-7]-pins$":
>> + properties:
>> + function:
>> + enum: [ pwr_pwrwake_sys, pwr_stop_forbidden, pwr_stdby_wakeup, pwr_encomp_vddcore,
>> + bsec_out_sec_niden, aiec_sys_wakeup, none, ddrctrl_lp_req,
>> + pwr_ddr_ret_enable_n, dts_clk_ptat, sram3ctrl_tamp_erase_act, gpoval0,
>> + pwr_sel_vth_vddcpu, pwr_mpu_ram_lowspeed, ca7_naxierrirq, pwr_okin_mr,
>> + bsec_out_sec_dbgen, aiec_c1_wakeup, rcc_pwrds_mpu, ddrctrl_dfi_ctrlupd_req,
>> + ddrctrl_cactive_ddrc_asr, sram3ctrl_hw_erase_act, nic400_s0_bready, gpoval1,
>> + pwr_pwrwake_mpu, pwr_mpu_clock_disable_ack, ca7_ndbgreset_i,
>> + bsec_in_rstcore_n, bsec_out_sec_bsc_dis, ddrctrl_dfi_init_complete,
>> + ddrctrl_perf_op_is_refresh, ddrctrl_gskp_dfi_lp_req, sram3ctrl_sw_erase_act,
>> + nic400_s0_bvalid, gpoval2, pwr_sel_vth_vddcore, pwr_mpu_clock_disable_req,
>> + ca7_npmuirq0, ca7_nfiqout0, bsec_out_sec_dftlock, bsec_out_sec_jtag_dis,
>> + rcc_pwrds_sys, sram3ctrl_tamp_erase_req, ddrctrl_stat_ddrc_reg_selfref_type0,
>> + dts_valobus1_0, dts_valobus2_0, tamp_potential_tamp_erfcfg, nic400_s0_wready,
>> + nic400_s0_rready, gpoval3, pwr_stop2_active, ca7_nl2reset_i,
>> + ca7_npreset_varm_i, bsec_out_sec_dften, bsec_out_sec_dbgswenable,
>> + eth1_out_pmt_intr_o, eth2_out_pmt_intr_o, ddrctrl_stat_ddrc_reg_selfref_type1,
>> + ddrctrl_cactive_0, dts_valobus1_1, dts_valobus2_1, tamp_nreset_sram_ercfg,
>> + nic400_s0_wlast, nic400_s0_rlast, gpoval4, ca7_standbywfil2,
>> + pwr_vth_vddcore_ack, ca7_ncorereset_i, ca7_nirqout0, bsec_in_pwrok,
>> + bsec_out_sec_deviceen, eth1_out_lpi_intr_o, eth2_out_lpi_intr_o,
>> + ddrctrl_cactive_ddrc, ddrctrl_wr_credit_cnt, dts_valobus1_2, dts_valobus2_2,
>> + pka_pka_itamp_out, nic400_s0_wvalid, nic400_s0_rvalid, gpoval5,
>> + ca7_standbywfe0, pwr_vth_vddcpu_ack, ca7_evento, bsec_in_tamper_det,
>> + bsec_out_sec_spniden, eth1_out_mac_speed_o1, eth2_out_mac_speed_o1,
>> + ddrctrl_csysack_ddrc, ddrctrl_lpr_credit_cnt, dts_valobus1_3, dts_valobus2_3,
>> + saes_tamper_out, nic400_s0_awready, nic400_s0_arready, gpoval6,
>> + ca7_standbywfi0, pwr_rcc_vcpu_rdy, ca7_eventi, ca7_dbgack0, bsec_out_fuse_ok,
>> + bsec_out_sec_spiden, eth1_out_mac_speed_o0, eth2_out_mac_speed_o0,
>> + ddrctrl_csysreq_ddrc, ddrctrl_hpr_credit_cnt, dts_valobus1_4, dts_valobus2_4,
>> + rng_tamper_out, nic400_s0_awavalid, nic400_s0_aravalid, gpoval7 ]
Do you know if it is possible to add an "and" in the if condition ?
I want to restrict the function name per pin name:
If compatible is "st,stm32mp131-hdp" and pin is "HDP2" then
function:
enum: [..]
Is it somehow feasible ?
Thank you
Clément
[...]
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/stm32mp1-clks.h>
>> +
>> + pinctrl@...90000 {
>> + compatible = "st,stm32mp15-hdp";
>> + reg = <0x54090000 0x400>;
>> + clocks = <&rcc HDP>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&hdp2_gpo>;
>> + hdp2_gpo: hdp2-pins {
>> + function = "gpoval2";
>> + pins = "HDP2";
>> + };
>> + };
>>
>> --
>> 2.43.0
>>
Powered by blists - more mailing lists