linux-kernel - Re: [PATCH v2 1/4] dt-bindings: leds: add lp5860 LED controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250521-versatile-hamster-of-completion-d96e0a@kuoka>
Date: Wed, 21 May 2025 11:02:40 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Steffen Trumtrar <s.trumtrar@...gutronix.de>
Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Steffen Trumtrar <kernel@...gutronix.de>, 
	Pavel Machek <pavel@...nel.org>, linux-leds@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: leds: add lp5860 LED controller

On Wed, May 14, 2025 at 12:36:28PM GMT, Steffen Trumtrar wrote:
> The lp5860 is a LED matrix driver with 18 constant current sinks and 11
> scan switches for 198 LED dots:
>   * Supply range from 2.7 V to 5.5 V
>   * 0.1mA - 50mA per current sink
>   * 1MHz I2C and 12MHz SPI control interface
>   * 8-bit analog dimming
>   * 8/16-bit PWM dimming
>   * individual ON and OFF control for each LED dot
>   * globat 3-bit Maximum Current setting for all LED dots
>   * individual LED dot open/short detection
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@...gutronix.de>
> ---
>  .../devicetree/bindings/leds/leds-lp5860.yaml      | 112 +++++++++++++++++++++
>  1 file changed, 112 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp5860.yaml b/Documentation/devicetree/bindings/leds/leds-lp5860.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..330ff42b27fb19395e64f813da4b0ab1fa22fe69
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-lp5860.yaml
> @@ -0,0 +1,112 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-lp5860.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LED driver for LP5860 RGB LED from Texas Instruments.
> +
> +maintainers:
> +  - Steffen Trumtrar <kernel@...gutronix.de>
> +
> +description: |
> +  The LP5860 is multi-channel, I2C and SPI RGB LED Driver that can group RGB LEDs
> +  into a LED group or control them individually.
> +
> +  For more product information please see the link below:
> +  https://www.ti.com/lit/ds/symlink/lp5860.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,lp5860
> +
> +  reg:
> +    maxItems: 1
> +
> +  spi-max-frequency:
> +    maximum: 12000000

So that's a SPI device? Where is the definition of this field? You miss
ref to peripheral props.

...

> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

And this is unevaluated. See other examples.

> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>

Where do you use this header?

> +    #include <dt-bindings/leds/common.h>
> +
> +    spi {
> +        #address-cells = <1>;

Best regards,
Krzysztof