linux-kernel - Re: [PATCH v2 net 1/2] net: hibmcge: fix incorrect statistics update issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250521091228.GS365796@horms.kernel.org>
Date: Wed, 21 May 2025 10:12:28 +0100
From: Simon Horman <horms@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, andrew+netdev@...n.ch, shenjian15@...wei.com,
	wangpeiyang1@...wei.com, liuyonglong@...wei.com,
	chenhao418@...wei.com, jonathan.cameron@...wei.com,
	shameerali.kolothum.thodi@...wei.com, salil.mehta@...wei.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net 1/2] net: hibmcge: fix incorrect statistics update
 issue

On Sat, May 17, 2025 at 05:58:27PM +0800, Jijie Shao wrote:
> When the user dumps statistics, the hibmcge driver automatically
> updates all statistics. If the driver is performing the reset operation,
> the error data of 0xFFFFFFFF is updated.
> 
> Therefore, if the driver is resetting, the hbg_update_stats_by_info()
> needs to return directly.
> 
> Fixes: c0bf9bf31e79 ("net: hibmcge: Add support for dump statistics")
> Signed-off-by: Jijie Shao <shaojijie@...wei.com>

Reviewed-by: Simon Horman <horms@...nel.org>