linux-kernel - [PATCH v2 0/3] virtio: Fixes for TX ring sizing and resize error reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250521092236.661410-1-lvivier@redhat.com>
Date: Wed, 21 May 2025 11:22:33 +0200
From: Laurent Vivier <lvivier@...hat.com>
To: linux-kernel@...r.kernel.org
Cc: "Michael S. Tsirkin" <mst@...hat.com>,
	netdev@...r.kernel.org,
	Jason Wang <jasowang@...hat.com>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Subject: [PATCH v2 0/3] virtio: Fixes for TX ring sizing and resize error reporting

This patch series contains two fixes and a cleanup for the virtio subsystem.

The first patch fixes an error reporting bug in virtio_ring's
virtqueue_resize() function. Previously, errors from internal resize
helpers could be masked if the subsequent re-enabling of the virtqueue
succeeded. This patch restores the correct error propagation, ensuring that
callers of virtqueue_resize() are properly informed of underlying resize
failures.

The second patch does a cleanup of the use of '2+MAX_SKB_FRAGS'

The third patch addresses a reliability issue in virtio_net where the TX
ring size could be configured too small, potentially leading to
persistently stopped queues and degraded performance. It enforces a
minimum TX ring size to ensure there's always enough space for at least one
maximally-fragmented packet plus an additional slot.

v2: clenup '2+MAX_SKB_FRAGS'

Laurent Vivier (3):
  virtio_ring: Fix error reporting in virtqueue_resize
  virtio_net: Cleanup '2+MAX_SKB_FRAGS'
  virtio_net: Enforce minimum TX ring size for reliability

 drivers/net/virtio_net.c     | 14 ++++++++++----
 drivers/virtio/virtio_ring.c |  8 ++++++--
 2 files changed, 16 insertions(+), 6 deletions(-)

-- 
2.49.0