linux-kernel - Re: [PATCH] [v2] ALSA: hda/cs35l41_hda: select FW_CS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8912514f-8d14-45a8-941d-bb57fbf756b2@opensource.cirrus.com>
Date: Wed, 21 May 2025 10:22:31 +0100
From: Richard Fitzgerald <rf@...nsource.cirrus.com>
To: Arnd Bergmann <arnd@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>
Cc: Arnd Bergmann <arnd@...db.de>, linux-sound@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] ALSA: hda/cs35l41_hda: select FW_CS_DSP

On 20/05/2025 5:20 pm, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When compile-testing this driver, the missing FW_CS_DSP module
> causes a link failure:
> 
> aarch64-linux-ld: sound/pci/hda/cs35l41_hda.o: in function `cs35l41_shutdown_dsp':
> cs35l41_hda.c:(.text+0x7e4): undefined reference to `cs_dsp_stop'
> aarch64-linux-ld: cs35l41_hda.c:(.text+0x7ec): undefined reference to `cs_dsp_power_down'
> aarch64-linux-ld: sound/pci/hda/cs35l41_hda.o: in function `cs35l41_hda_remove':
> cs35l41_hda.c:(.text+0x14b4): undefined reference to `cs_dsp_remove'
> aarch64-linux-ld: sound/pci/hda/cs35l41_hda.o: in function `cs35l41_smart_amp.isra.0':
> cs35l41_hda.c:(.text+0x189c): undefined reference to `cs_dsp_halo_init'
> aarch64-linux-ld: cs35l41_hda.c:(.text+0x1bd4): undefined reference to `cs_dsp_power_up'
> aarch64-linux-ld: cs35l41_hda.c:(.text+0x1c38): undefined reference to `cs_dsp_run'
> aarch64-linux-ld: cs35l41_hda.c:(.text+0x1c80): undefined reference to `cs_dsp_get_ctl'
> aarch64-linux-ld: cs35l41_hda.c:(.text+0x1c90): undefined reference to `cs_dsp_coeff_read_ctrl'
> aarch64-linux-ld: cs35l41_hda.c:(.text+0x1cd4): undefined reference to `cs_dsp_get_ctl'
> aarch64-linux-ld: cs35l41_hda.c:(.text+0x1ce4): undefined reference to `cs_dsp_coeff_read_ctrl'
> 
> Fixes: bdd9ea9187c4 ("ALSA: hda/hda_cs_dsp_ctl: Delete hda_cs_dsp_ctl module")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> v2: fix subject and Fixes line to point to the correct change
> ---
Yes, this is definitely my fault. I should have noticed that the module
I removed created an indirect dependency on FW_CS_DSP that needed
copying to the parent codec driver Kconfig. The L56 Kconfig already
selected FW_CS_DSP but L41 didn't.

Reviewed-by: Richard Fitzgerald <rf@...nsource.cirrus.com>