linux-kernel - Re: [PATCH 1/2] dt-bindings: gnss: u-blox: add "safeboot-gpios" binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250521-qualified-smart-myna-bddfc8@kuoka>
Date: Wed, 21 May 2025 11:27:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alejandro Enrique <alejandroe1@...tab.com>
Cc: Johan Hovold <johan@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: gnss: u-blox: add "safeboot-gpios"
 binding

On Wed, May 14, 2025 at 03:54:41PM GMT, Alejandro Enrique wrote:
> U-Blox M8/M9 chip have a pin to start it in safeboot mode, to be used
> to recover from situations where the flash content has become
> corrupted and needs to be restored. Introduce a binding to support
> this safeboot pin.
> 
> Signed-off-by: Alejandro Enrique <alejandroe1@...tab.com>
> ---
>  Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> index 7d4b6d49e5eea2201ac05ba6d54b1c1721172f26..16d922279def99257c194520a7ac820f2a26e9c7 100644
> --- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> +++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> @@ -32,6 +32,9 @@ properties:
>    reset-gpios:
>      maxItems: 1
>  
> +  safeboot-gpios:
> +    maxItems: 1
> +

You need if:then: disallowing (:false) this for 6m and 8. Move entire allOf down
and add there new if: clause. (see example schema)

>    vcc-supply:
>      description: >
>        Main voltage regulator
> @@ -61,5 +64,6 @@ examples:
>              v-bckp-supply = <&gnss_v_bckp_reg>;
>              vcc-supply = <&gnss_vcc_reg>;
>              reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
> +            safeboot-gpios = <&gpio 2 GPIO_ACTIVE_LOW>;

Thats 8, not 8m?

Best regards,
Krzysztof