linux-kernel - Re: [PATCH 1/4] dt-bindings: arm: qcom: Add Lenovo Thinkbook 16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb403a64-205c-479b-b203-0926389d34fd@oldschoolsolutions.biz>
Date: Wed, 21 May 2025 11:37:56 +0200
From: Jens Glathe <jens.glathe@...schoolsolutions.biz>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Johan Hovold <johan+linaro@...nel.org>,
 Aleksandrs Vinarskis <alex.vinarskis@...il.com>
Subject: Re: [PATCH 1/4] dt-bindings: arm: qcom: Add Lenovo Thinkbook 16

On 21.05.25 11:31, Krzysztof Kozlowski wrote:
> On Thu, May 15, 2025 at 10:38:55PM GMT, Jens Glathe wrote:
>> Document the x1p-42-100/x1-26-100 variants of the Thinkbook 16 G7 QOY.
>>
>> [1]: https://psref.lenovo.com/syspool/Sys/PDF/ThinkBook/ThinkBook_16_G7_QOY/ThinkBook_16_G7_QOY_Spec.pdf
>>
>> Signed-off-by: Jens Glathe <jens.glathe@...schoolsolutions.biz>
>> ---
>>   Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index a61c85a47e2e759c7c86f3bd49f8597fc5054929..42d22e2fb7817810742a15226807bd6a984e6acd 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -1152,8 +1152,10 @@ properties:
>>         - items:
>>             - enum:
>>                 - asus,zenbook-a14-ux3407qa
>> +              - lenovo,thinkbook-16
>>                 - qcom,x1p42100-crd
>>             - const: qcom,x1p42100
>> +          - const: qcom,x1e80100
> You break existing DTS without any explanation in commit msg. What's
> more, your commit msg says something quite different than you are doing
> here.

My bad, v2 is also still wrong. Preparing a v3 which will only add the 
Thinkbook 16 to qcom.yaml and only say compatible to qcom, x1p42100.

with best regards

Jens