linux-kernel - Re: [PATCH v2 1/3] cgroup, docs: be specific about bandwidth control of rt processes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <OSZPR01MB67115CCC104221C27EE63709939EA@OSZPR01MB6711.jpnprd01.prod.outlook.com>
Date: Wed, 21 May 2025 01:14:53 +0000
From: "Shashank.Mahadasyam@...y.com" <Shashank.Mahadasyam@...y.com>
To: Tejun Heo <tj@...nel.org>
CC: Johannes Weiner <hannes@...xchg.org>,
        Michal Koutný
	<mkoutny@...e.com>,
        Jonathan Corbet <corbet@....net>,
        "cgroups@...r.kernel.org" <cgroups@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Shinya.Takumi@...y.com" <Shinya.Takumi@...y.com>
Subject: Re: [PATCH v2 1/3] cgroup, docs: be specific about bandwidth control
 of rt processes

Hi Tejun,

On 21 May 2025 5:11, Tejun Heo wrote:
> > -WARNING: cgroup2 cpu controller doesn't yet fully support the control of
> > +WARNING: cgroup2 cpu controller doesn't yet support the (bandwidth) control of
>
> This reads weird to me. Without the () part, it becomes "doesn't yet support
> the control of". Maybe rephrase it a bit more?

I'm not sure how to rephrase it. It sounds fine to me 😅 Moreover, "doesn't yet support the control of" was the wording when the warning paragraph on RT_GROUP_SCHED was added in commit c2f31b79 (cgroup: add warning about RT not being supported on cgroup2). Would removing the parentheses, making it "doesn't yet support the bandwidth control of", sound better?

Thank you

Regards,
Shashank

________________________________________
From: Tejun Heo <tj@...nel.org>
Sent: 21 May 2025 5:11
To: Mahadasyam, Shashank (SGC)
Cc: Johannes Weiner; Michal Koutný; Jonathan Corbet; cgroups@...r.kernel.org; linux-doc@...r.kernel.org; linux-kernel@...r.kernel.org; Takumi, Shinya (SGC)
Subject: Re: [PATCH v2 1/3] cgroup, docs: be specific about bandwidth control of rt processes

On Tue, May 20, 2025 at 11: 07: 45PM +0900, Shashank Balaji via B4 Relay wrote: > From: Shashank Balaji <shashank. mahadasyam@ sony. com> > > Signed-off-by: Shashank Balaji <shashank. mahadasyam@ sony. com> > --- > Documentation/admin-guide/cgroup-v2. rst


On Tue, May 20, 2025 at 11:07:45PM +0900, Shashank Balaji via B4 Relay wrote:
> From: Shashank Balaji <shashank.mahadasyam@...y.com>
>
> Signed-off-by: Shashank Balaji <shashank.mahadasyam@...y.com>
> ---
>  Documentation/admin-guide/cgroup-v2.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 1a16ce68a4d7f6f8c9070be89c4975dbfa79077e..3b3685736fe9b12e96a273248dfb4a8c62a4b698 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1076,7 +1076,7 @@ cpufreq governor about the minimum desired frequency which should always be
>  provided by a CPU, as well as the maximum desired frequency, which should not
>  be exceeded by a CPU.
>
> -WARNING: cgroup2 cpu controller doesn't yet fully support the control of
> +WARNING: cgroup2 cpu controller doesn't yet support the (bandwidth) control of

This reads weird to me. Without the () part, it becomes "doesn't yet support
the control of". Maybe rephrase it a bit more?

Thanks.

--
tejun