linux-kernel - Re: [PATCH 4/4] mips: dts: qca: add wmac support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b00c3805-aa8c-40d7-a882-66f59f777747@kernel.org>
Date: Wed, 21 May 2025 13:09:06 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rosen Penev <rosenp@...il.com>, linux-wireless@...r.kernel.org
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Toke Høiland-Jørgensen <toke@...e.dk>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, "open list:MIPS" <linux-mips@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] mips: dts: qca: add wmac support

On 21/05/2025 04:15, Rosen Penev wrote:
> Now that OF ahb support was added to the ath9k driver, we can use it to
> enable and use the SoC wireless found in these chipsets.
> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>
> ---
>  arch/mips/boot/dts/qca/ar9132.dtsi                       | 9 +++++++++
>  arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts         | 4 ++++
>  arch/mips/boot/dts/qca/ar9331.dtsi                       | 9 +++++++++
>  arch/mips/boot/dts/qca/ar9331_dpt_module.dts             | 4 ++++
>  arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts           | 4 ++++
>  arch/mips/boot/dts/qca/ar9331_omega.dts                  | 4 ++++
>  .../mips/boot/dts/qca/ar9331_openembed_som9331_board.dts | 4 ++++
>  arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts              | 4 ++++
>  8 files changed, 42 insertions(+)
> 
> diff --git a/arch/mips/boot/dts/qca/ar9132.dtsi b/arch/mips/boot/dts/qca/ar9132.dtsi
> index 61dcfa5b6ca7..dc94459aa3e9 100644
> --- a/arch/mips/boot/dts/qca/ar9132.dtsi
> +++ b/arch/mips/boot/dts/qca/ar9132.dtsi
> @@ -156,6 +156,15 @@ spi: spi@...00000 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  		};
> +
> +		wmac: wmac@...c0000 {

The name is enforced by bindings now (if you tested that). It's wifi.

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on
distro packages for dtschema and be sure you are using the latest
released dtschema.

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Best regards,
Krzysztof