linux-kernel - Re: [PATCH 3/3] ARM: dts: mxs: support i.MX28 Amarula rmm board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5D-d7bmBfXKe936W5QjmsukRRX3y0ge+xtizqFx0HPE8A@mail.gmail.com>
Date: Wed, 21 May 2025 08:40:41 -0300
From: Fabio Estevam <festevam@...il.com>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc: linux-kernel@...r.kernel.org, linux-amarula@...rulasolutions.com, 
	michael@...rulasolutions.com, Conor Dooley <conor+dt@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Pengutronix Kernel Team <kernel@...gutronix.de>, 
	Rob Herring <robh@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Shawn Guo <shawnguo@...nel.org>, devicetree@...r.kernel.org, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/3] ARM: dts: mxs: support i.MX28 Amarula rmm board

Hi Dario,

On Wed, May 21, 2025 at 6:28 AM Dario Binacchi
<dario.binacchi@...rulasolutions.com> wrote:
>
> The board includes the following resources:
>  - 256 Mbytes NAND Flash
>  - 256 Mbytes SRAM

SRAM or DDR?

>  - LCD-TFT controller

The LCD support is not described in the dts.

> +/ {
> +       model = "Amarula i.MX28 rmm";
> +       compatible = "amarula,imx28-rmm", "fsl,imx28";
> +
> +       memory@...00000 {
> +               device_type = "memory";
> +               reg = <0x40000000 0x08000000>;

In the commit log, you say 256 MB, but here we have 128 MB.

> +&i2c0 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&i2c0_pins_a>;
> +       status = "okay";
> +
> +       polytouch: edt-ft5x06@38 {

Node names should be generic: touchscreen@38

> +
> +&pinctrl {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&hog_pins_a>;
> +
> +       hog_pins_a: hog-0 {
> +               reg = <0>;
> +               fsl,pinmux-ids = <
> +                       MX28_PAD_LCD_RESET__GPIO_3_30 /* LCD reset */
> +                       MX28_PAD_SSP2_SS1__GPIO_2_20  /* External power */

Proper panel bindings should better describe these pins than hog pins.

Do you plan to add display support?