linux-kernel - Re: [PATCH] staging: vme_user: add missing includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025052136-backstab-dork-de2d@gregkh>
Date: Wed, 21 May 2025 13:43:24 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Heikki Huttu <heissendo88@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] staging: vme_user: add missing includes

On Thu, May 15, 2025 at 10:40:13PM +0300, Heikki Huttu wrote:
> Header files use u32, size_t, dma_addr_t, struct device, struct list_head.
> Add direct includes to make the headers self-contained.
> 
> Signed-off-by: Heikki Huttu <heissendo88@...il.com>
> ---
>  drivers/staging/vme_user/vme.h      | 5 +++++
>  drivers/staging/vme_user/vme_user.h | 2 ++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/staging/vme_user/vme.h b/drivers/staging/vme_user/vme.h
> index 7753e736f9fd..55499b240dc3 100644
> --- a/drivers/staging/vme_user/vme.h
> +++ b/drivers/staging/vme_user/vme.h
> @@ -3,6 +3,11 @@
>  #define _VME_H_
>  
>  #include <linux/bitops.h>
> +#include <linux/types.h>
> +#include <linux/device.h>
> +#include <linux/list.h>
> +#include <linux/mm.h>
> +#include <linux/dma-mapping.h>

If you are going to add these, please do so in a sorted way.

But really, why is this needed at all?

>  
>  /* Resource Type */
>  enum vme_resource_type {
> diff --git a/drivers/staging/vme_user/vme_user.h b/drivers/staging/vme_user/vme_user.h
> index 19ecb05781cc..297b25fab164 100644
> --- a/drivers/staging/vme_user/vme_user.h
> +++ b/drivers/staging/vme_user/vme_user.h
> @@ -2,6 +2,8 @@
>  #ifndef _VME_USER_H_
>  #define _VME_USER_H_
>  
> +#include <linux/types.h>

Same here, are you sure this is needed?

thanks,

greg k-h