linux-kernel - Re: [PATCH] staging: sm750fb: rename `regValue` to `reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025052130-verdict-limb-8b1a@gregkh>
Date: Wed, 21 May 2025 13:45:50 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Eric Florin <ericflorin@...gle.com>
Cc: teddy.wang@...iconmotion.com, sudipm.mukherjee@...il.com,
	linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: sm750fb: rename `regValue` to `reg_value`

On Mon, May 05, 2025 at 08:30:13PM -0700, Eric Florin wrote:
> Rename `regValue` to `reg_value` in `write_dpr` to conform with style
> guidelines as reported by checkpatch.pl
> 
> CHECK: Avoid CamelCase: <regValue>
> 
> Signed-off-by: Eric Florin <ericflorin@...gle.com>
> ---
>  drivers/staging/sm750fb/sm750_accel.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index 44b9e3fe3a41..5648476a8f3c 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -17,9 +17,10 @@
>  
>  #include "sm750.h"
>  #include "sm750_accel.h"
> -static inline void write_dpr(struct lynx_accel *accel, int offset, u32 regValue)
> +static inline void write_dpr(struct lynx_accel *accel, int offset,
> +			     u32 reg_value)

You also wrapped this line, why?  It should be fine as-is.

thanks,

greg k-h