linux-kernel - Re: [PATCH v2] can: dev: add struct data_bittiming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b5e3351-9435-4d4c-9553-98b7d0112fd8@wanadoo.fr>
Date: Wed, 21 May 2025 21:14:26 +0900
From: Vincent Mailhol <mailhol.vincent@...adoo.fr>
To: Marc Kleine-Budde <mkl@...gutronix.de>
Cc: Oliver Hartkopp <socketcan@...tkopp.net>, linux-can@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] can: dev: add struct data_bittiming_params to group FD
 parameters

Hi Marc,

On 02/05/2025 at 21:34, Marc Kleine-Budde wrote:
> On 02.05.2025 02:12:10, Vincent Mailhol wrote:
>> This is a preparation patch for the introduction of CAN XL.
>>
>> CAN FD and CAN XL uses similar bittiming parameters. Add one level of
>> nesting for all the CAN FD parameters. Typically:
>>
>>   priv->can.data_bittiming;
>>
>> becomes:
>>
>>   priv->can.fd.data_bittiming;
>>
>> This way, the CAN XL equivalent (to be introduced later) would be:
>>
>>   priv->can.xl.data_bittiming;
>>
>> Add the new struct data_bittiming_params which contains all the data
>> bittiming parameters, including the TDC and the callback functions.
>>
>> This done, update all the CAN FD drivers to make use of the new
>> layout.
> 
> Thanks for the series!
> 
>> Acked-by: Oliver Hartkopp <socketcan@...tkopp.net>
>> Signed-off-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>
>> ---
>> The CAN XL series is still blocked because of lack of information on
>> the PWMS and PWML calculations, c.f.:
>>
>>   https://lore.kernel.org/linux-can/68e8c449-a6ab-4958-af3c-852ece2694c2@wanadoo.fr/
>>
>> Regardless, the above patch will be needed at some time. And instead
>> of constantly rebasing it, I would rather have it merged early.
>>
>> The other CAN XL preparation patches target a smaller subset of the
>> tree and rebasing those is not an issue.
>>
>> ** Changelog **
>>
>> v1 -> v2:
>>
>>   - add Oliver's Acked-by tag
>>   - rebase on top of:
>>
>>       [PATCH v5] can: mcp251xfd: fix TDC setting for low data bit rates
>>       Link: https://lore.kernel.org/linux-can/20250430161501.79370-1-kelsey@vpprocess.com/T/#u
>>
>>   Link: https://lore.kernel.org/linux-can/20250320144154.56611-2-mailhol.vincent@wanadoo.fr/
> 
> As "mcp251xfd: fix TDC setting for low data bit rates" will go through
> the "can" and "net" tree, we have to wait until "net" is merged back to
> "net-next".

That commit now reached the net tree. Do you think that my patch can now be applied?


Yours sincerely,
Vincent Mailhol