linux-kernel - Re: [PATCH V1 2/2] mmc: sdhci-uhs2: Adjust some error messages and register dump for SD UHS-II card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFqsKqw2Oy2_JCK9ts1DytkMo86snWw9-OdxYwJfNWbnqw@mail.gmail.com>
Date: Wed, 21 May 2025 14:44:58 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Victor Shih <victorshihgli@...il.com>
Cc: adrian.hunter@...el.com, linux-mmc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, benchuanggli@...il.com, 
	HL.Liu@...esyslogic.com.tw, Greg.tu@...esyslogic.com.tw, 
	Ben Chuang <ben.chuang@...esyslogic.com.tw>, 
	Victor Shih <victor.shih@...esyslogic.com.tw>
Subject: Re: [PATCH V1 2/2] mmc: sdhci-uhs2: Adjust some error messages and
 register dump for SD UHS-II card

On Wed, 21 May 2025 at 12:45, Victor Shih <victorshihgli@...il.com> wrote:
>
> On Mon, May 19, 2025 at 8:25 PM Ulf Hansson <ulf.hansson@...aro.org> wrote:
> >
> > On Fri, 16 May 2025 at 11:27, Victor Shih <victorshihgli@...il.com> wrote:
> > >
> > > From: Victor Shih <victor.shih@...esyslogic.com.tw>
> > >
> > > Adjust some error messages to debug mode and register dump to dynamic
> > > debug mode to avoid causing misunderstanding it is an error.
> >
> > Dumping the register may be useful for the debug level, I am not sure.
> > Maybe Adrian has an opinion?
> >
> > >
> > > Signed-off-by: Ben Chuang <ben.chuang@...esyslogic.com.tw>
> > > Signed-off-by: Victor Shih <victor.shih@...esyslogic.com.tw>
> > > ---
> > >  drivers/mmc/host/sdhci-uhs2.c | 18 +++++++++---------
> > >  drivers/mmc/host/sdhci.h      | 16 ++++++++++++++++
> > >  2 files changed, 25 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/drivers/mmc/host/sdhci-uhs2.c b/drivers/mmc/host/sdhci-uhs2.c
> > > index c53b64d50c0d..9ff867aee985 100644
> > > --- a/drivers/mmc/host/sdhci-uhs2.c
> > > +++ b/drivers/mmc/host/sdhci-uhs2.c
> > > @@ -99,8 +99,8 @@ void sdhci_uhs2_reset(struct sdhci_host *host, u16 mask)
> > >         /* hw clears the bit when it's done */
> > >         if (read_poll_timeout_atomic(sdhci_readw, val, !(val & mask), 10,
> > >                                      UHS2_RESET_TIMEOUT_100MS, true, host, SDHCI_UHS2_SW_RESET)) {
> > > -               pr_warn("%s: %s: Reset 0x%x never completed. %s: clean reset bit.\n", __func__,
> > > -                       mmc_hostname(host->mmc), (int)mask, mmc_hostname(host->mmc));
> > > +               DBG("%s: %s: Reset 0x%x never completed. %s: clean reset bit.\n", __func__,
> > > +                   mmc_hostname(host->mmc), (int)mask, mmc_hostname(host->mmc));
> >
> > As I said on patch1, please use pr_debug() and drop the macro.
> >
>
> Hi, Ulf
>
> This macro has been defined in previous patches not the first time it
> has appeared here,
> are we still going to drop this macro?

Yes, please.

We don't have macros for other log-prints, so let's not use a macro
for debug prints either.

[...]

Kind regards
Uffe