linux-kernel - Re: [REPOST PATCH net-next] xsk: add missing virtual address conversion for page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73e378b8-a51a-473a-a8db-c8e989e2ee0a@intel.com>
Date: Wed, 21 May 2025 14:53:22 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Bui Quang Minh <minhquangbui99@...il.com>
CC: <netdev@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>, "Daniel
 Borkmann" <daniel@...earbox.net>, "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Jesper Dangaard Brouer <hawk@...nel.org>,
	John Fastabend <john.fastabend@...il.com>, Eric Dumazet
	<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>, Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
	<bpf@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [REPOST PATCH net-next] xsk: add missing virtual address
 conversion for page

From: Bui Quang Minh <minhquangbui99@...il.com>
Date: Wed, 21 May 2025 16:00:35 +0700

> In commit 7ead4405e06f ("xsk: convert xdp_copy_frags_from_zc() to use
> page_pool_dev_alloc()"), when converting from netmem to page, I missed a
> call to page_address() around skb_frag_page(frag) to get the virtual
> address of the page. This commit uses skb_frag_address() helper to fix
> the issue.
> 
> Signed-off-by: Bui Quang Minh <minhquangbui99@...il.com>

As for the code, then:

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

But you need to add "Fixes:" tag pointing to the commit you mention.

> ---
>  net/core/xdp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/core/xdp.c b/net/core/xdp.c
> index e6f22ba61c1e..491334b9b8be 100644
> --- a/net/core/xdp.c
> +++ b/net/core/xdp.c
> @@ -709,8 +709,7 @@ static noinline bool xdp_copy_frags_from_zc(struct sk_buff *skb,
>  			return false;
>  		}
>  
> -		memcpy(page_address(page) + offset,
> -		       skb_frag_page(frag) + skb_frag_off(frag),
> +		memcpy(page_address(page) + offset, skb_frag_address(frag),
>  		       LARGEST_ALIGN(len));
>  		__skb_fill_page_desc_noacc(sinfo, i, page, offset, len);

Thanks,
Olek