linux-kernel - Re: [PATCH 1/9] tools/nolibc: move ioctl() to sys/ioctl.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <744a1aa8-1efc-4c20-b45e-070fc038f6e8@sirena.org.uk>
Date: Wed, 21 May 2025 14:22:30 +0100
From: Mark Brown <broonie@...nel.org>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Willy Tarreau <w@....eu>, Shuah Khan <shuah@...nel.org>,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 1/9] tools/nolibc: move ioctl() to sys/ioctl.h

On Wed, May 21, 2025 at 03:08:05PM +0200, Thomas Weißschuh wrote:
> On 2025-05-21 14:03:37+0100, Mark Brown wrote:

> > > +/* make sure to include all global symbols */
> > > +#include "nolibc.h"

> > assumes that the nolibc include directory is in the include path, or
> > otherwise set up with a -I path, previously you just had to include
> > nolibc.h with the includes that are there working due to being relative
> > to nolibc.h.  I'll send a patch for the arm64 tests.

> Thanks for the report.
> Inside sys/ this should actually be #include "../nolibc.h".
> I'll doublecheck all of sys/ and see why our new header checks didn't
> catch this.

Ah, you expect what's currently there to work - good.  I noticed that
the vDSO tests had a -I for the nolibc directory which made me think it
was expected that it be there, it's the only user on most arches.

> > It looks like the RISC-V selftests are also impacted, I didn't spot any
> > other users that didn't already have an -I.

> No changes to the selftests should be necessary.

OK, that's easier for me!

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)