linux-kernel - Re: [PATCH v3 1/2] USB: core: add a memory pool to urb caching host-controller private data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f22dd1b0-fe1a-49a4-931d-15d57589b03b@linux.intel.com>
Date: Wed, 21 May 2025 16:34:53 +0300
From: Mathias Nyman <mathias.nyman@...ux.intel.com>
To: David Wang <00107082@....com>, Mathias Nyman <mathias.nyman@...el.com>
Cc: gregkh@...uxfoundation.org, oneukum@...e.com, stern@...land.harvard.edu,
 linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] USB: core: add a memory pool to urb caching
 host-controller private data

On 21.5.2025 16.23, David Wang wrote:

>> Won't this still allocate a lot of unnecessary memory for the roothub urbs?
>> i.e. the ones queued with rh_urb_enqueue(hcd, urb).
>> The host drivers don't use the urb->hcpriv of those URBs.
>>
> The mempool slot is alloced on demand when hcd request private data with its urb.
> If a urb is  ever used by hcd and the  hcd requests private data with it, a  memory would be alloced
> and this memory will not be released until the urb is destroyed.

Ok, thanks for the clarification.
Roothubs URBs should be fine then.

Thanks
Mathias