linux-kernel - Re: [PATCH v3] net/mlx5: Add error handling in mlx5_query_nic_vport_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202505221016.r93lwUfJ-lkp@intel.com>
Date: Thu, 22 May 2025 11:12:35 +0800
From: kernel test robot <lkp@...el.com>
To: Wentao Liang <vulab@...as.ac.cn>, saeedm@...dia.com, leon@...nel.org,
	tariqt@...dia.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	Wentao Liang <vulab@...as.ac.cn>, stable@...r.kernel.org
Subject: Re: [PATCH v3] net/mlx5: Add error handling in
 mlx5_query_nic_vport_node_guid()

Hi Wentao,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]
[also build test ERROR on net/main linus/master v6.15-rc7 next-20250521]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Wentao-Liang/net-mlx5-Add-error-handling-in-mlx5_query_nic_vport_node_guid/20250521-212557
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250521132343.844-1-vulab%40iscas.ac.cn
patch subject: [PATCH v3] net/mlx5: Add error handling in mlx5_query_nic_vport_node_guid()
config: loongarch-randconfig-002-20250522 (https://download.01.org/0day-ci/archive/20250522/202505221016.r93lwUfJ-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250522/202505221016.r93lwUfJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505221016.r93lwUfJ-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/ethernet/mellanox/mlx5/core/vport.c: In function 'mlx5_query_nic_vport_node_guid':
>> drivers/net/ethernet/mellanox/mlx5/core/vport.c:474:9: error: 'ret' undeclared (first use in this function); did you mean 'net'?
     474 |         ret = mlx5_query_nic_vport_context(mdev, 0, out);
         |         ^~~
         |         net
   drivers/net/ethernet/mellanox/mlx5/core/vport.c:474:9: note: each undeclared identifier is reported only once for each function it appears in


vim +474 drivers/net/ethernet/mellanox/mlx5/core/vport.c

   463	
   464	int mlx5_query_nic_vport_node_guid(struct mlx5_core_dev *mdev, u64 *node_guid)
   465	{
   466		u32 *out;
   467		int outlen = MLX5_ST_SZ_BYTES(query_nic_vport_context_out);
   468		int err;
   469	
   470		out = kvzalloc(outlen, GFP_KERNEL);
   471		if (!out)
   472			return -ENOMEM;
   473	
 > 474		ret = mlx5_query_nic_vport_context(mdev, 0, out);
   475		if (err)
   476			goto out;
   477	
   478		*node_guid = MLX5_GET64(query_nic_vport_context_out, out,
   479					nic_vport_context.node_guid);
   480	out:
   481		kvfree(out);
   482	
   483		return err;
   484	}
   485	EXPORT_SYMBOL_GPL(mlx5_query_nic_vport_node_guid);
   486	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki