linux-kernel - Re: [PATCH 1/2] dt-bindings: regulator: mediatek: Add MT8196 vmm controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42a7222b-43be-490a-95ed-fb506c55fbcb@kernel.org>
Date: Thu, 22 May 2025 17:18:50 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Nancy.Lin" <nancy.lin@...iatek.com>,
 Chun-Kuang Hu <chunkuang.hu@...nel.org>, Liam Girdwood
 <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: Mark Brown <broonie@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Project_Global_Chrome_Upstream_Group@...iatek.com,
 jason-jh.lin@...iatek.com, singo.chang@...iatek.com,
 paul-pl.chen@...iatek.com
Subject: Re: [PATCH 1/2] dt-bindings: regulator: mediatek: Add MT8196 vmm
 controller

On 22/05/2025 17:09, Krzysztof Kozlowski wrote:
> On 22/05/2025 17:03, Nancy.Lin wrote:
>> From: Nancy Lin <nancy.lin@...iatek.com>
>>
>> Add a device tree binding document for the MediaTek MT8196 VMM (Vcore
>> for MultiMedia) regulator controller. The VMM controller acts as the
>> main power supplier for multimedia power domains, such as those used
>> by display, video encode and decode subsystems. It provides virtual
>> regulators that serve as the power sources for various multimedia IPs,
> 
> Virtual regulators do not sound real, so feels like you want some sort
> of power domains?
> 
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Wrong keyword... Please fix the subject prefixes:

For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Best regards,
Krzysztof