linux-kernel - Re: [PATCH v2 2/3] dt-bindings: pwm: adi,axi-pwmgen: fix clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b538701d-cfb1-4e86-994b-0a8f394e8335@kernel.org>
Date: Thu, 22 May 2025 17:19:48 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: David Lechner <dlechner@...libre.com>,
 Michael Hennerich <michael.hennerich@...log.com>,
 Nuno Sá <nuno.sa@...log.com>,
 Trevor Gamblin <tgamblin@...libre.com>,
 Uwe Kleine-König <ukleinek@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: pwm: adi,axi-pwmgen: fix clocks

On 22/05/2025 17:17, David Lechner wrote:
> On 5/22/25 10:00 AM, Krzysztof Kozlowski wrote:
>> On 22/05/2025 16:49, David Lechner wrote:
>>> Fix a shortcoming in the bindings that doesn't allow for a separate
>>> external clock.
>>>
>>> The AXI PWMGEN IP block has a compile option ASYNC_CLK_EN that allows
>>> the use of an external clock for the PWM output separate from the AXI
>>> clock that runs the peripheral.
>>>
>>> This was missed in the original bindings and so users were writing dts
>>> files where the one and only clock specified would be the external
>>> clock, if there was one, incorrectly missing the separate AXI clock.
>>>
>>> The correct bindings are that the AXI clock is always required and the
>>> external clock is optional (must be given only when HDL compile option
>>> ASYNC_CLK_EN=1).
>>>
>>> Fixes: 1edf2c2a2841 ("dt-bindings: pwm: Add AXI PWM generator")
>>> Signed-off-by: David Lechner <dlechner@...libre.com>
>>> ---
>>>  Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml | 14 ++++++++++++--
>>>  1 file changed, 12 insertions(+), 2 deletions(-)
>>
>> Please test your patches. This does not pass build (binding_check). :/
>>
> 
> Oh no, I knew I was forgetting something. :-(
> 
> Maybe time to see about building this into b4 prep --check so it won't
> be so easy to forget.
> 
> The correct will be:
> 
> 
>   clock-names:
>     oneOf:
>       - const: axi
>       - items:
>           - const: axi
>           - const: ext


Then just
minItems: 1
items:
  - foo
  - bar

Best regards,
Krzysztof