linux-kernel - Re: [PATCH] EDAC/bluefield: dont use bluefield_edac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250522162015.GEaC9Ov72e1AEPivj4@fat_crate.local>
Date: Thu, 22 May 2025 18:20:15 +0200
From: Borislav Petkov <bp@...en8.de>
To: David Thompson <davthompson@...dia.com>
Cc: Shravan Ramani <shravankr@...dia.com>,
	"tony.luck@...el.com" <tony.luck@...el.com>,
	"james.morse@....com" <james.morse@....com>,
	"mchehab@...nel.org" <mchehab@...nel.org>,
	"rric@...nel.org" <rric@...nel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] EDAC/bluefield: dont use bluefield_edac_readl result on
 error

On Thu, May 22, 2025 at 03:41:23PM +0000, David Thompson wrote:
> > -----Original Message-----
> > From: David Thompson <davthompson@...dia.com>
> > Sent: Tuesday, March 18, 2025 5:48 PM
> > To: Shravan Ramani <shravankr@...dia.com>; bp@...en8.de;
> > tony.luck@...el.com; james.morse@....com; mchehab@...nel.org;
> > rric@...nel.org
> > Cc: linux-edac@...r.kernel.org; linux-kernel@...r.kernel.org; David Thompson
> > <davthompson@...dia.com>
> > Subject: [PATCH] EDAC/bluefield: dont use bluefield_edac_readl result on error
> > 
> > The "bluefield_edac_readl()" routine returns an uninitialized result during error
> > paths. In those cases the calling routine should not use the uninitialized result.
> > The driver should simply log the error, and then return early.
> > 
> > Fixes: e41967575474 ("EDAC/bluefield: Use Arm SMC for EMI access on
> > BlueField-2")
> > Signed-off-by: David Thompson <davthompson@...dia.com>
> > Reviewed-by: Shravan Kumar Ramani <shravankr@...dia.com>
> > ---
> >  drivers/edac/bluefield_edac.c | 20 +++++++++++++++-----
> >  1 file changed, 15 insertions(+), 5 deletions(-)
> > 
> 
> Refreshing this review...
> 
> Does anyone have feedback on this EDAC driver patch?

Looks like it fell through the cracks... :-\

Queued now.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette