linux-kernel - Re: [PATCH] wifi: mwifiex: enable host mlme on sdio W8997 chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aC9dvv6Ki1T5RsHF@google.com>
Date: Thu, 22 May 2025 10:24:14 -0700
From: Brian Norris <briannorris@...omium.org>
To: rafael@...ms.me
Cc: Francesco Dolcini <francesco@...cini.it>,
	Rafael Beims <rafael.beims@...adex.com>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: mwifiex: enable host mlme on sdio W8997 chipsets

On Wed, May 21, 2025 at 07:19:34AM -0300, rafael@...ms.me wrote:
> From: Rafael Beims <rafael.beims@...adex.com>
> 
> Enable the host mlme flag for W8997 chipsets so WPA3 can be used.
> This feature depends on firmware support (V2 API key), which may not be
> available in all available firmwares.

Is it available in *any* W8997 firmware? Or particularly, is it
available in the firmware in linux-firmware.git? Judging by its git
history, the answer is "no", in which case this is definitely NAK'd.

At a minimum, can you post what FW version you're testing with? This is
the bare minimum required for this kind of patch on many other drivers,
although I'm not sure we've been so strict on mwifiex.

And even if it works for *some* firmware, I'd generally highly encourage
not making breaking changes like this, where there's a long history of
users on the old FW version. So, we'd need to teach the driver to know
the difference between v1 and v2 API here, and choose accordingly.

Brian

> Signed-off-by: Rafael Beims <rafael.beims@...adex.com>
> ---
> Tested on a Verdin iMX8MP (SDIO-UART) and Verdin iMX8MM (SDIO-SDIO):
>     - created AP's requiring WPA2 and WPA3 authentication and successfully
>       connected clients to them.
>     - connected as a client to AP's requiring WPA2 and WPA3 authentication
> ---
>  drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
> index c1fe48448839..f039d6f19183 100644
> --- a/drivers/net/wireless/marvell/mwifiex/sdio.c
> +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
> @@ -438,7 +438,7 @@ static const struct mwifiex_sdio_device mwifiex_sdio_sd8997 = {
>  	.can_auto_tdls = false,
>  	.can_ext_scan = true,
>  	.fw_ready_extra_delay = false,
> -	.host_mlme = false,
> +	.host_mlme = true,
>  };
>  
>  static const struct mwifiex_sdio_device mwifiex_sdio_sd8887 = {
> -- 
> 2.47.2
>