linux-kernel - Re: [PATCH v2] dt-bindings: gnss: add u-blox,neo-9m compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab6bfdd7-13af-4abd-94e1-25fb3d0edb1c@kernel.org>
Date: Thu, 22 May 2025 19:36:28 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: alejandroe1@...tab.com, Johan Hovold <johan@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: gnss: add u-blox,neo-9m compatible

On 22/05/2025 18:18, Alejandro Enrique via B4 Relay wrote:
> From: Alejandro Enrique <alejandroe1@...tab.com>
> 
> Add compatible for u-blox NEO-9M GPS module.
> 
> Signed-off-by: Alejandro Enrique <alejandroe1@...tab.com>
> ---
> This series just add the compatible string for u-blox NEO-9M module,
> using neo-m8 as fallback. I have tested the driver with such a module
> and it is working fine.
> ---
> Changes in v2:
> - Modify the binding to allow falling back to neo-m8
> - Remove compatible string from u-blox driver
> - Link to v1: https://lore.kernel.org/r/20250514-ubx-m9-v1-0-193973a4f3ca@geotab.com
> ---
>  Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 25 +++++++++++++++++++++----
>  1 file changed, 21 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> index 7d4b6d49e5eea2201ac05ba6d54b1c1721172f26..215f8931ca08c1b0954fc2f70eabe3ec8d89edea 100644
> --- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> +++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> @@ -18,10 +18,16 @@ description: >
>  
>  properties:
>    compatible:
> -    enum:
> -      - u-blox,neo-6m
> -      - u-blox,neo-8
> -      - u-blox,neo-m8
> +    oneOf:
> +      - items:

Drop items here, just enum directly.

> +          - enum:
> +              - u-blox,neo-6m
> +              - u-blox,neo-8
> +              - u-blox,neo-m8
> +

Drop blank line.

> +      - items:
> +          - const: u-blox,neo-m9
> +          - const: u-blox,neo-m8
>  
>    reg:
>      description: >
> @@ -63,3 +69,14 @@ examples:
>              reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
>          };
>      };
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    serial {
> +        gnss {
> +            compatible = "u-blox,neo-m9", "u-blox,neo-m8";

No need for new example, it's the same as previous.


Best regards,
Krzysztof