linux-kernel - Re: [PATCH v3 00/12] qrb4210-rb2: add wsa audio playback and capture support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1225a93d-e298-4477-81a6-e871b9d771f3@linaro.org>
Date: Thu, 22 May 2025 19:47:55 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Alexey Klimov <alexey.klimov@...aro.org>,
 Srinivas Kandagatla <srini@...nel.org>, Mark Brown <broonie@...nel.org>,
 linux-sound@...r.kernel.org
Cc: Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Dmitry Baryshkov <lumag@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>,
 Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v3 00/12] qrb4210-rb2: add wsa audio playback and capture
 support

On 22/05/2025 19:40, Alexey Klimov wrote:
> Rebased, updated, re-tested. This implements the playback support via the
> following path: RX1 from DSP is connected to rxmacro which communicates
> with wcd codec using soundwire. This goes into AUX input of wcd. Wcd codec
> outputs analog audio into wsa8815 amplifier. Capturing works through vamacro
> using one onboard DMIC which is directly connected to vamacro codec.
> 
> Changes since v2:
> -- dropped [PATCH v2 08/14] dt-bindings: arm: qcom-soc: extend pattern matching
> to support qcom,wsa881x and replaced with new one;
> -- dropped [PATCH v2 14/14] ASoC: qcom: sm8250: force single channel via RX_1 output for qrb4210
> -- reordered as suggested by Krzysztof;
> -- updates to wsa881x-common.h registers descriptions and corresponding updates
> to wsa881x-common.c (Konrad);
> -- sorted subnodes in DT alphabetically as suggested by Konrad;
> -- wsa881x bindings updates (as suggested by Krzysztof);

What exactly changed? This is way too vague.

> -- ASoC: dt-bindings: qcom: Add SM6115 LPASS rxmacro and vamacro codecs
> is still present;

What does it mean "still present"? You never responded to my comment. I
never asked to remove it, so I do not get why you mention it is still
present.

Best regards,
Krzysztof