linux-kernel - Re: [PATCH v1 1/1] x86/fred/signal: Prevent single-step upon ERETU completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8342ee1c-5adc-4a6a-b4ee-f7d3b42a6528@intel.com>
Date: Thu, 22 May 2025 10:54:43 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Xin Li <xin@...or.com>, kernel test robot <lkp@...el.com>,
 linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, tglx@...utronix.de, mingo@...hat.com,
 bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
 peterz@...radead.org, andrew.cooper3@...rix.com, stable@...r.kernel.org
Subject: Re: [PATCH v1 1/1] x86/fred/signal: Prevent single-step upon ERETU
 completion

On 5/22/25 10:33, Xin Li wrote:
>>>> arch/x86/include/asm/sighandling.h:44:21: error: 'struct pt_regs'
>>>> has no member named 'fred_ss'
>>        44 |                 regs->fred_ss.swevent = 0;
>>           |                     ^~
>>
> 
> Hmm, this statement is under IS_ENABLED(CONFIG_X86_FRED), which should

The compiler still _compiles_ unreachable statements:

	if (0)
		foo = bar.bar;

An #ifdef will keep the compiler out completely, of course. That's
probably the best thing in this case, especially since it'll be tucked
away in a header.