linux-kernel - Re: [PATCH v3 01/10] dt-bindings: npu: rockchip,rknn: Add bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c261c9aad759d791e0a576a47bbd064f28148e9.camel@ndufresne.ca>
Date: Thu, 22 May 2025 14:03:00 -0400
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: "Rob Herring (Arm)" <robh@...nel.org>, Tomeu Vizoso
 <tomeu@...euvizoso.net>
Cc: David Airlie <airlied@...il.com>, devicetree@...r.kernel.org, Thomas
 Zimmermann <tzimmermann@...e.de>, Maxime Ripard <mripard@...nel.org>,
 linux-kernel@...r.kernel.org,  Conor Dooley <conor+dt@...nel.org>, Oded
 Gabbay <ogabbay@...nel.org>, Maarten Lankhorst	
 <maarten.lankhorst@...ux.intel.com>, Jonathan Corbet <corbet@....net>, 
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org, 
	linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
 Christian König	 <christian.koenig@....com>, Jeff Hugo
 <jeff.hugo@....qualcomm.com>, Sumit Semwal <sumit.semwal@...aro.org>, Heiko
 Stuebner <heiko@...ech.de>, Krzysztof Kozlowski	 <krzk+dt@...nel.org>,
 Nicolas Frattaroli <nicolas.frattaroli@...labora.com>,  Simona Vetter
 <simona@...ll.ch>, linux-rockchip@...ts.infradead.org,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 01/10] dt-bindings: npu: rockchip,rknn: Add bindings

Hi Rob,


Le lundi 19 mai 2025 à 06:35 -0500, Rob Herring (Arm) a écrit :
> 
> On Fri, 16 May 2025 18:53:15 +0200, Tomeu Vizoso wrote:
> > Add the bindings for the Neural Processing Unit IP from Rockchip.
> > 
> > v2:
> > - Adapt to new node structure (one node per core, each with its own
> >   IOMMU)
> > - Several misc. fixes from Sebastian Reichel
> > 
> > v3:
> > - Split register block in its constituent subblocks, and only require
> >   the ones that the kernel would ever use (Nicolas Frattaroli)
> > - Group supplies (Rob Herring)
> > - Explain the way in which the top core is special (Rob Herring)
> > 
> > Signed-off-by: Tomeu Vizoso <tomeu@...euvizoso.net>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> > ---
> >  .../bindings/npu/rockchip,rknn-core.yaml           | 162 +++++++++++++++++++++
> >  1 file changed, 162 insertions(+)
> > 
> 
> My bot found errors running 'make dt_binding_check' on your patch:

Yes, and it found and reported it 25 times, can you fix it please ?

Nicolas

> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/npu/rockchip,rknn-core.yaml: properties:reg-
> names: 'oneOf' conditional failed, one must be fixed:
> 	[{'const': 'pc'}, {'const': 'cna'}, {'const': 'core'}] is too long
> 	[{'const': 'pc'}, {'const': 'cna'}, {'const': 'core'}] is too short
> 	False schema does not allow 3
> 	1 was expected
> 	3 is greater than the maximum of 2
> 	hint: "minItems" is only needed if less than the "items" list length
> 	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/npu/rockchip,rknn-core.example.dtb:
> npu-core@...b0000 (rockchip,rk3588-rknn-core-top): compatible: 'oneOf' conditional failed, one must be fixed:
> 	['rockchip,rk3588-rknn-core-top', 'rockchip,rknn-core-top'] is too long
> 	'rockchip,rk3588-rknn-core-top' is not one of ['rockchip,rk3588-rknn-core']
> 	from schema $id: http://devicetree.org/schemas/npu/rockchip,rknn-core.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/npu/rockchip,rknn-core.example.dtb:
> npu-core@...b0000 (rockchip,rk3588-rknn-core-top): reg: [[0, 4255842304, 0, 36864]] is too short
> 	from schema $id: http://devicetree.org/schemas/npu/rockchip,rknn-core.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/npu/rockchip,rknn-core.example.dtb:
> npu-core@...c0000 (rockchip,rk3588-rknn-core): compatible: 'oneOf' conditional failed, one must be fixed:
> 	['rockchip,rk3588-rknn-core', 'rockchip,rknn-core'] is too long
> 	'rockchip,rk3588-rknn-core' is not one of ['rockchip,rk3588-rknn-core-top']
> 	from schema $id: http://devicetree.org/schemas/npu/rockchip,rknn-core.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/npu/rockchip,rknn-core.example.dtb:
> npu-core@...c0000 (rockchip,rk3588-rknn-core): reg: [[0, 4255907840, 0, 36864]] is too short
> 	from schema $id: http://devicetree.org/schemas/npu/rockchip,rknn-core.yaml#
> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250516-6-10-rocket-v3-1-7051ac9225db@tomeuvizoso.net
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>