linux-kernel - Re: [PATCH v3 3/4] KVM: s390: refactor and split some gmap helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DA2VZ43MN9WS.I6PHR04W4WKV@linux.ibm.com>
Date: Thu, 22 May 2025 20:04:20 +0200
From: "Christoph Schlameuss" <schlameuss@...ux.ibm.com>
To: "Claudio Imbrenda" <imbrenda@...ux.ibm.com>,
        <linux-kernel@...r.kernel.org>
Cc: <kvm@...r.kernel.org>, <linux-s390@...r.kernel.org>,
        <frankja@...ux.ibm.com>, <borntraeger@...ibm.com>,
        <seiden@...ux.ibm.com>, <nsg@...ux.ibm.com>, <nrb@...ux.ibm.com>,
        <david@...hat.com>, <hca@...ux.ibm.com>, <agordeev@...ux.ibm.com>,
        <svens@...ux.ibm.com>, <gor@...ux.ibm.com>
Subject: Re: [PATCH v3 3/4] KVM: s390: refactor and split some gmap helpers

On Thu May 22, 2025 at 3:22 PM CEST, Claudio Imbrenda wrote:
> Refactor some gmap functions; move the implementation into a separate
> file with only helper functions. The new helper functions work on vm
> addresses, leaving all gmap logic in the gmap functions, which mostly
> become just wrappers.
>
> The whole gmap handling is going to be moved inside KVM soon, but the
> helper functions need to touch core mm functions, and thus need to
> stay in the core of kernel.
>

Reviewed-by: Christoph Schlameuss <schlameuss@...ux.ibm.com>

> Signed-off-by: Claudio Imbrenda <imbrenda@...ux.ibm.com>
> ---
>  MAINTAINERS                          |   2 +
>  arch/s390/include/asm/gmap.h         |   2 -
>  arch/s390/include/asm/gmap_helpers.h |  15 ++
>  arch/s390/kvm/diag.c                 |  13 +-
>  arch/s390/kvm/kvm-s390.c             |   5 +-
>  arch/s390/mm/Makefile                |   2 +
>  arch/s390/mm/gmap.c                  | 157 +------------------
>  arch/s390/mm/gmap_helpers.c          | 223 +++++++++++++++++++++++++++
>  8 files changed, 259 insertions(+), 160 deletions(-)
>  create mode 100644 arch/s390/include/asm/gmap_helpers.h
>  create mode 100644 arch/s390/mm/gmap_helpers.c

[...]