linux-kernel - Re: [PATCH] selftests/mm: Deduplicate test names in madv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aboathzpwqqgy5j3jw53cubmrtlzelazdysksqnfb5niruto43@ptubjb5ptakg>
Date: Thu, 22 May 2025 14:59:45 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Mark Brown <broonie@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Shuah Khan <shuah@...nel.org>,
        David Hildenbrand <david@...hat.com>, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/mm: Deduplicate test names in madv_populate

* Mark Brown <broonie@...nel.org> [250522 12:30]:
> The madv_populate selftest has some repetitive code for several different
> cases that it covers, included repeated test names used in ksft_test_result()
> reports. This causes problems for automation, the test name is used to both
> track the test between runs and distinguish between multiple tests within
> the same run. Fix this by tweaking the messages with duplication to be more
> specific about the contexts they're in.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>

Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>

> ---
>  tools/testing/selftests/mm/madv_populate.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/tools/testing/selftests/mm/madv_populate.c b/tools/testing/selftests/mm/madv_populate.c
> index ef7d911da13e..b6fabd5c27ed 100644
> --- a/tools/testing/selftests/mm/madv_populate.c
> +++ b/tools/testing/selftests/mm/madv_populate.c
> @@ -172,12 +172,12 @@ static void test_populate_read(void)
>  	if (addr == MAP_FAILED)
>  		ksft_exit_fail_msg("mmap failed\n");
>  	ksft_test_result(range_is_not_populated(addr, SIZE),
> -			 "range initially not populated\n");
> +			 "read range initially not populated\n");
>  
>  	ret = madvise(addr, SIZE, MADV_POPULATE_READ);
>  	ksft_test_result(!ret, "MADV_POPULATE_READ\n");
>  	ksft_test_result(range_is_populated(addr, SIZE),
> -			 "range is populated\n");
> +			 "read range is populated\n");
>  
>  	munmap(addr, SIZE);
>  }
> @@ -194,12 +194,12 @@ static void test_populate_write(void)
>  	if (addr == MAP_FAILED)
>  		ksft_exit_fail_msg("mmap failed\n");
>  	ksft_test_result(range_is_not_populated(addr, SIZE),
> -			 "range initially not populated\n");
> +			 "write range initially not populated\n");
>  
>  	ret = madvise(addr, SIZE, MADV_POPULATE_WRITE);
>  	ksft_test_result(!ret, "MADV_POPULATE_WRITE\n");
>  	ksft_test_result(range_is_populated(addr, SIZE),
> -			 "range is populated\n");
> +			 "write range is populated\n");
>  
>  	munmap(addr, SIZE);
>  }
> @@ -247,19 +247,19 @@ static void test_softdirty(void)
>  	/* Clear any softdirty bits. */
>  	clear_softdirty();
>  	ksft_test_result(range_is_not_softdirty(addr, SIZE),
> -			 "range is not softdirty\n");
> +			 "cleared range is not softdirty\n");
>  
>  	/* Populating READ should set softdirty. */
>  	ret = madvise(addr, SIZE, MADV_POPULATE_READ);
> -	ksft_test_result(!ret, "MADV_POPULATE_READ\n");
> +	ksft_test_result(!ret, "softdirty MADV_POPULATE_READ\n");
>  	ksft_test_result(range_is_not_softdirty(addr, SIZE),
> -			 "range is not softdirty\n");
> +			 "range is not softdirty after MADV_POPULATE_READ\n");
>  
>  	/* Populating WRITE should set softdirty. */
>  	ret = madvise(addr, SIZE, MADV_POPULATE_WRITE);
> -	ksft_test_result(!ret, "MADV_POPULATE_WRITE\n");
> +	ksft_test_result(!ret, "softdirty MADV_POPULATE_WRITE\n");
>  	ksft_test_result(range_is_softdirty(addr, SIZE),
> -			 "range is softdirty\n");
> +			 "range is softdirty after MADV_POPULATE_WRITE \n");
>  
>  	munmap(addr, SIZE);
>  }
> 
> ---
> base-commit: a5806cd506af5a7c19bcd596e4708b5c464bfd21
> change-id: 20250521-selftests-mm-madv-populate-dedupe-95faf16c3c8f
> 
> Best regards,
> -- 
> Mark Brown <broonie@...nel.org>
> 
>