linux-kernel - Re: [PATCH] ALSA: hda_acpi: eliminate defined but not used warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aC-TKm55YkzvG47N@ddadap-lakeline.nvidia.com>
Date: Thu, 22 May 2025 16:12:10 -0500
From: Daniel Dadap <ddadap@...dia.com>
To: Takashi Iwai <tiwai@...e.de>
Cc: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org,
	Jaroslav Kysela <perex@...ex.cz>, linux-sound@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda_acpi: eliminate defined but not used warnings

On Thu, May 22, 2025 at 10:42:17PM +0200, Takashi Iwai wrote:
> On Thu, 22 May 2025 22:30:20 +0200,
> Randy Dunlap wrote:
> > 
> > When CONFIG_PM_SLEEP is not set, the hda_acpi_suspend() and
> > hda_acpi_resume() functions are not used and cause build warnings:
> > 
> > sound/pci/hda/hda_acpi.c:282:12: warning: 'hda_acpi_resume' defined but not used [-Wunused-function]
> >   282 | static int hda_acpi_resume(struct device *dev)
> > sound/pci/hda/hda_acpi.c:269:12: warning: 'hda_acpi_suspend' defined but not used [-Wunused-function]
> >   269 | static int hda_acpi_suspend(struct device *dev)
> > 
> > Enclose these functions inside an ifdef CONFIG_PM_SLEEP block to
> > prevent the warnings.
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > Cc: Daniel Dadap <ddadap@...dia.com>
> > Cc: Takashi Iwai <tiwai@...e.de>
> > Cc: Jaroslav Kysela <perex@...ex.cz>
> > Cc: linux-sound@...r.kernel.org
> 
> Err, it just an incorrect use of SET_SYSTEM_SLEEP_PM_OPS() instead of
> SYSTEM_SLEEP_OPS().  It seems that v5 patch went back to a wrong
> macro, likely mistakenly.
> 

Sorry about that, I'm not sure how that change got lost between v3 and v5.
(I also introduced a typo in the commit message of v5 that wasn't in the
original patch, oops.)

> A fix patch will follow.
> 
> 
> thanks,
> 
> Takashi