linux-kernel - Re: [PATCH] selftests: acct: fix grammar and clarify output messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2ad679c-7c68-44c1-b4fb-20b3d02a7c35@linuxfoundation.org>
Date: Thu, 22 May 2025 15:27:03 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Abdelrahman Fekry <abdelrahmanfekry375@...il.com>, shuah@...nel.org
Cc: linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] selftests: acct: fix grammar and clarify output messages

On 5/13/25 16:14, Abdelrahman Fekry wrote:
> This patch improves the clarity and grammar of output messages in the acct()
> selftest. Minor changes were made to user-facing strings and comments to make
> them easier to understand and more consistent with the kselftest style.
> 
> Changes include:
> - Fixing grammar in printed messages and comments.
> - Rewording error and success outputs for clarity and professionalism.
> - Making the "root check" message more direct.
> 
> These updates improve readability without affecting test logic or behavior.
> 
> Signed-off-by: Abdelrahman Fekry <Abdelrahmanfekry375@...il.com>

Did you run checkpatch on this patch? I am seeing

CHECK: From:/Signed-off-by: email comments mismatch: 'From: Abdelrahman Fekry <abdelrahmanfekry375@...il.com>' != 'Signed-off-by: Abdelrahman Fekry <Abdelrahmanfekry375@...il.com>'

Please fix it and send v2.

thanks,
-- Shuah