linux-kernel - Re: [PATCH] staging: rtl8723bs: rename _Read_EEPROM to _read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025052246-boxing-swung-31b2@gregkh>
Date: Thu, 22 May 2025 06:42:45 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Donny Turizo <donnyturizo13@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: rename _Read_EEPROM to _read_eeprom

On Thu, May 22, 2025 at 03:15:38AM +0000, Donny Turizo wrote:
> From: Donny-Dev <donnyturizo13@...il.com>
> 
> Fixes a checkpath warning by renaming the function
> _Read_EEPROM to follow the kernel coding style (snake_case).

Why just this one?

> 
> Signed-off-by: Donny Turizo <donnyturizo13@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c         | 2 +-
>  drivers/staging/rtl8723bs/include/rtw_cmd.h      | 2 +-
>  drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 49bcefb5e8d2..a0b85beffe5d 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -15,7 +15,7 @@ static struct _cmd_callback rtw_cmd_callback[] = {
>  	{GEN_CMD_CODE(_Write_BBREG), NULL},
>  	{GEN_CMD_CODE(_Read_RFREG), &rtw_getbbrfreg_cmdrsp_callback},
>  	{GEN_CMD_CODE(_Write_RFREG), NULL}, /*5*/
> -	{GEN_CMD_CODE(_Read_EEPROM), NULL},
> +	{GEN_CMD_CODE(_read_eeprom), NULL},

Are you sure this is correct?  Aren't these commands that come from the
hardware and show up on a datasheet somewhere?  Don't rename things that
are referenced outside of the kernel in a different way if at all
possible.

thanks,

greg k-h