linux-kernel - Re: [PATCH] perf test: Add cgroup summary test case for perf trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aC-hHTgArwlF_zu9@x1>
Date: Thu, 22 May 2025 19:11:41 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Namhyung Kim <namhyung@...nel.org>, Howard Chu <howardchu95@...il.com>
Cc: Ian Rogers <irogers@...gle.com>, Kan Liang <kan.liang@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf test: Add cgroup summary test case for perf trace

On Thu, May 22, 2025 at 01:49:37PM -0300, Arnaldo Carvalho de Melo wrote:
> On Thu, May 22, 2025 at 08:33:16AM -0700, Howard Chu wrote:
> > $ sudo /tmp/perf/perf test -vv 112
> > 112: perf trace summary:
> > 112: perf trace summary
> > --- start ---
> > test child forked, pid 1574993
> > testing: perf trace -s -- true
> > testing: perf trace -S -- true
> > testing: perf trace -s --summary-mode=thread -- true
> > testing: perf trace -S --summary-mode=total -- true
> > testing: perf trace -as --summary-mode=thread --no-bpf-summary -- true
> > testing: perf trace -as --summary-mode=total --no-bpf-summary -- true
> > testing: perf trace -as --summary-mode=thread --bpf-summary -- true
> > testing: perf trace -as --summary-mode=total --bpf-summary -- true
> > testing: perf trace -aS --summary-mode=total --bpf-summary -- true
> > testing: perf trace -as --summary-mode=cgroup --bpf-summary -- true
> > testing: perf trace -aS --summary-mode=cgroup --bpf-summary -- true
> > ---- end(0) ----
> > 112: perf trace summary                                              : Ok
 
> Thanks, tested and applied to perf-tools-next,

But then when running all the tests, since this does system wide
tracing, it fails:

112: perf trace summary                                              : FAILED!

It works with the following patch applied, please check and ack/review:

>From 8c868979d886e2e88aa89f4e3d884e1b6450a7b2 Mon Sep 17 00:00:00 2001
From: Arnaldo Carvalho de Melo <acme@...hat.com>
Date: Thu, 22 May 2025 19:01:47 -0300
Subject: [PATCH 1/1] perf tests trace_summary.sh: Run in exclusive mode

And it is being successfull only when running alone, probably because
there are some tests that add the vfs_getname probe that gets used by
'perf trace' and alter how it does syscall arg pathname resolution.

This should be removed or made a fallback to the preferred BPF mode of
getting syscall parameters, but till then, run this in exclusive mode.

For reference, here are some of the tests that run close to this one:

  127: perf record offcpu profiling tests                              : Ok
  128: perf all PMU test                                               : Ok
  129: perf stat --bpf-counters test                                   : Ok
  130: Check Arm CoreSight trace data recording and synthesized samples: Skip
  131: Check Arm CoreSight disassembly script completes without errors : Skip
  132: Check Arm SPE trace data recording and synthesized samples      : Skip
  133: Test data symbol                                                : Ok
  134: Miscellaneous Intel PT testing                                  : Skip
  135: test Intel TPEBS counting mode                                  : Skip
  136: perf script task-analyzer tests                                 : Ok
  137: Check open filename arg using perf trace + vfs_getname          : Ok
  138: perf trace summary                                              : Ok

Cc: Adrian Hunter <adrian.hunter@...el.com>
Cc: Howard Chu <howardchu95@...il.com>
Cc: Ian Rogers <irogers@...gle.com>
Cc: James Clark <james.clark@...aro.org>
Cc: Jiri Olsa <jolsa@...nel.org>
Cc: Kan Liang <kan.liang@...ux.intel.com>
Cc: Namhyung Kim <namhyung@...nel.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
 tools/perf/tests/shell/trace_summary.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/shell/trace_summary.sh b/tools/perf/tests/shell/trace_summary.sh
index bb350dfabdc2bf5e..49766524dc21b534 100755
--- a/tools/perf/tests/shell/trace_summary.sh
+++ b/tools/perf/tests/shell/trace_summary.sh
@@ -1,5 +1,5 @@
 #!/bin/sh
-# perf trace summary
+# perf trace summary (exclusive)
 # SPDX-License-Identifier: GPL-2.0
 
 # Check that perf trace works with various summary mode
-- 
2.49.0