linux-kernel - Re: [PATCH 1/1] Fix typo in cpu-on-off-test selftest script:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a2980c99-6a6e-42ac-8978-8e0ab5319a9c@linuxfoundation.org>
Date: Thu, 22 May 2025 16:43:37 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Jihed Chaibi <jihed.chaibi.dev@...il.com>, shuah@...nel.org
Cc: linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH 1/1] Fix typo in cpu-on-off-test selftest script:

On 5/16/25 19:19, Jihed Chaibi wrote:
> Fix typo in hotplaggable_offline_cpus function name:
> 
> "hotplaggable" is replaced by "hotpluggable"
> 
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@...il.com>
> ---

Change looks good to me. Change log should specify the
subsusystem. Check submitting patches document and refer
to a few change logs for this file using git log.

Send v2 with a proper change log.

>   tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh b/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh
> index d5dc7e0dc..6232a46ca 100755
> --- a/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh
> +++ b/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh
> @@ -67,7 +67,7 @@ hotpluggable_cpus()
>   	done
>   }
>   
> -hotplaggable_offline_cpus()
> +hotpluggable_offline_cpus()
>   {
>   	hotpluggable_cpus 0
>   }
> @@ -151,7 +151,7 @@ offline_cpu_expect_fail()
>   
>   online_all_hot_pluggable_cpus()
>   {
> -	for cpu in `hotplaggable_offline_cpus`; do
> +	for cpu in `hotpluggable_offline_cpus`; do
>   		online_cpu_expect_success $cpu
>   	done
>   }

thanks,
-- Shuah