linux-kernel - Re: [PATCH v2] selftests: Add functional test for the abort file in fusectl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57f3f9ec-41bf-4a7b-b4b2-a4dd78ad7801@linuxfoundation.org>
Date: Thu, 22 May 2025 16:49:42 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Chen Linxuan <chenlinxuan@...ontech.com>, Shuah Khan <shuah@...nel.org>,
 Miklos Szeredi <miklos@...redi.hu>
Cc: zhanjun@...ontech.com, niecheng1@...ontech.com, wentao@...ontech.com,
 Amir Goldstein <amir73il@...il.com>, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] selftests: Add functional test for the abort file in
 fusectl

On 5/16/25 19:23, Chen Linxuan wrote:
> This patch add a simple functional test for the "abort" file
> in fusectlfs (/sys/fs/fuse/connections/ID/about).
> 
> A simple fuse daemon is added for testing.
> 
> Related discussion can be found in the link below.
> 
> Link: https://lore.kernel.org/all/CAOQ4uxjKFXOKQxPpxtS6G_nR0tpw95w0GiO68UcWg_OBhmSY=Q@mail.gmail.com/
> Cc: Amir Goldstein <amir73il@...il.com>
> Signed-off-by: Chen Linxuan <chenlinxuan@...ontech.com>
> ---
> Changes in v2:
> - Apply changes suggested by Amir Goldstein
>    - Check errno
> - Link to v1: https://lore.kernel.org/all/20250515073449.346774-2-chenlinxuan@uniontech.com/

Short summary should include the test name:

selftests: filesystems: Add functional test for the abort file in fusectl

Also if this test requires root previlege, add check for it. The rest
looks good to me.

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah