[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d4bf97a2-15ae-4093-bdf9-63c78d07eb4a@intel.com>
Date: Thu, 22 May 2025 16:05:59 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Babu Moger <babu.moger@....com>, <corbet@....net>, <tony.luck@...el.com>,
<tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>,
<dave.hansen@...ux.intel.com>
CC: <james.morse@....com>, <dave.martin@....com>, <fenghuay@...dia.com>,
<x86@...nel.org>, <hpa@...or.com>, <paulmck@...nel.org>,
<akpm@...ux-foundation.org>, <thuth@...hat.com>, <rostedt@...dmis.org>,
<ardb@...nel.org>, <gregkh@...uxfoundation.org>,
<daniel.sneddon@...ux.intel.com>, <jpoimboe@...nel.org>,
<alexandre.chartre@...cle.com>, <pawan.kumar.gupta@...ux.intel.com>,
<thomas.lendacky@....com>, <perry.yuan@....com>, <seanjc@...gle.com>,
<kai.huang@...el.com>, <xiaoyao.li@...el.com>, <kan.liang@...ux.intel.com>,
<xin3.li@...el.com>, <ebiggers@...gle.com>, <xin@...or.com>,
<sohil.mehta@...el.com>, <andrew.cooper3@...rix.com>,
<mario.limonciello@....com>, <linux-doc@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <peternewman@...gle.com>,
<maciej.wieczor-retman@...el.com>, <eranian@...gle.com>,
<Xiaojian.Du@....com>, <gautham.shenoy@....com>
Subject: Re: [PATCH v13 16/27] x86/resctrl: Pass entire struct rdtgroup rather
than passing individual members
Hi Babu,
On 5/15/25 3:52 PM, Babu Moger wrote:
> The mbm_cntr_assign mode requires a cntr_id to read event data. The
cntr_id -> "counter ID"
> cntr_id is retrieved via mbm_cntr_get, which takes a struct rdtgroup as
cntr_id -> "counter ID"
mbm_cntr_get -> mbm_cntr_get()
> a parameter.
>
> Passing the full rdtgroup also provides access to closid and rmid, both of
closid -> CLOSID
rmid -> RMID
> which are necessary to read monitoring events.
>
> Refactor the code to pass the entire struct rdtgroup instead of individual
"the entire" -> "a pointer to"
> members in preparation for this requirement.
>
> Suggested-by: Reinette Chatre <reinette.chatre@...el.com>
> Signed-off-by: Babu Moger <babu.moger@....com>
> ---
Patch looks good.
Reinette
Powered by blists - more mailing lists