linux-kernel - RE: [PATCH 0/6] mailbox: Trivial updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB845984111A32B341294716C48899A@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Thu, 22 May 2025 00:52:01 +0000
From: Peng Fan <peng.fan@....com>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>, Jassi Brar
	<jassisinghbrar@...il.com>
CC: Tudor Ambarus <tudor.ambarus@...aro.org>, Elliot Berman
	<quic_eberman@...cinc.com>, Thierry Reding <treding@...dia.com>, Sudeep Holla
	<sudeep.holla@....com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "mailbox@...ts.linux.dev"
	<mailbox@...ts.linux.dev>
Subject: RE: [PATCH 0/6] mailbox: Trivial updates

Hi Jassi,

> Subject: [PATCH 0/6] mailbox: Trivial updates

Any comments?

Thanks,
Peng
> 
> Several trivial updates to cleanup code.
> - use dev_err for print err information
> - propagate correct error value
> - use guard/scoped_guard
> - drop devm_mbox_controller_unregister
> 
> Tested on i.MX95 with SCMI mailbox Transport
> 
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
> Peng Fan (6):
>       mailbox: Use dev_err when there is error
>       mailbox: Not protect module_put with spin_lock_irqsave
>       mailbox: Propagate correct error return value
>       mailbox: Remove devm_mbox_controller_unregister
>       mailbox: Use guard/scoped_guard for con_mutex
>       mailbox: Use guard/scoped_guard for spinlock
> 
>  drivers/mailbox/mailbox.c          | 199 ++++++++++++++----------------------
> -
>  include/linux/mailbox_controller.h |   3 -
>  2 files changed, 74 insertions(+), 128 deletions(-)
> ---
> base-commit: c10fe6005a47b49097119488ebb0cc80301623a8
> change-id: 20250409-mailbox-cleanup-56d920f13cb8
> 
> Best regards,
> --
> Peng Fan <peng.fan@....com>