linux-kernel - [PATCH] thermal: qcom: ipq5018: make ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250522-ipq5018-tsens-sparse-v1-1-97edaaaef27c@outlook.com>
Date: Thu, 22 May 2025 09:48:51 +0400
From: George Moussalem via B4 Relay <devnull+george.moussalem.outlook.com@...nel.org>
To: Amit Kucheria <amitk@...nel.org>, 
 Thara Gopinath <thara.gopinath@...il.com>, 
 "Rafael J. Wysocki" <rafael@...nel.org>, 
 Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>, 
 Lukasz Luba <lukasz.luba@....com>
Cc: linux-pm@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
 linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>, 
 George Moussalem <george.moussalem@...look.com>
Subject: [PATCH] thermal: qcom: ipq5018: make ops_ipq5018 struct static

From: George Moussalem <george.moussalem@...look.com>

Fix a sparse warning by making the ops_ipq5018 struct static.

Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505202356.S21Sc7bk-lkp@intel.com/
Signed-off-by: George Moussalem <george.moussalem@...look.com>
---
Fix below sparse warning by making the ops_ipq5018 struct static.

sparse warnings: (new ones prefixed by >>)
>> drivers/thermal/qcom/tsens-v1.c:246:24: sparse: sparse: symbol 'ops_ipq5018' was not declared. Should it be static?

vim +/ops_ipq5018 +246 drivers/thermal/qcom/tsens-v1.c

   245	
 > 246	const struct tsens_ops ops_ipq5018 = {
   247		.init		= init_tsens_v1_no_rpm,
   248		.calibrate	= tsens_calibrate_common,
   249		.get_temp	= get_temp_tsens_valid,
   250	};
   251	
---
 drivers/thermal/qcom/tsens-v1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/qcom/tsens-v1.c b/drivers/thermal/qcom/tsens-v1.c
index 27360e70d62a94e52e67f5aaa45457be165bfeb3..faa5d00788ca6fb29b367857d27596578218358e 100644
--- a/drivers/thermal/qcom/tsens-v1.c
+++ b/drivers/thermal/qcom/tsens-v1.c
@@ -243,7 +243,7 @@ struct tsens_plat_data data_8976 = {
 	.fields		= tsens_v1_regfields,
 };

-const struct tsens_ops ops_ipq5018 = {
+static const struct tsens_ops ops_ipq5018 = {
 	.init		= init_tsens_v1_no_rpm,
 	.calibrate	= tsens_calibrate_common,
 	.get_temp	= get_temp_tsens_valid,

---
base-commit: 54b982e44c486d604583efe8742557ab56c944e0
change-id: 20250521-ipq5018-tsens-sparse-4b86d97dbb17

Best regards,
-- 
George Moussalem <george.moussalem@...look.com>