linux-kernel - Re: [PATCH] pci: altera: remove unused 'node' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <beb25d1b-e7d9-4de9-83f6-4b6bf6616bda@app.fastmail.com>
Date: Thu, 22 May 2025 08:32:46 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Jiri Slaby" <jirislaby@...nel.org>, "Arnd Bergmann" <arnd@...nel.org>,
 "Thomas Gleixner" <tglx@...utronix.de>
Cc: "Joyce Ooi" <joyce.ooi@...el.com>, "Bjorn Helgaas" <bhelgaas@...gle.com>,
 linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pci: altera: remove unused 'node' variable

On Thu, May 22, 2025, at 07:53, Jiri Slaby wrote:
> On 21. 05. 25, 18:29, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> This variable is only used when CONFIG_OF is enabled:
>> 
>> drivers/pci/controller/pcie-altera.c: In function 'altera_pcie_init_irq_domain':
>> drivers/pci/controller/pcie-altera.c:855:29: error: unused variable 'node' [-Werror=unused-variable]
>>    855 |         struct device_node *node = dev->of_node;
>> 
>> Use dev_fwnode() in place of of_node_to_fwnode() to avoid this.
>
> Reviewed-by: Jiri Slaby <jirislaby@...nel.org>
>
> Right, this reminds me that my dev_fwnode() patches (in my local queue 
> -- they were supposed to be in v3) are not only cleanup, but also fix 
> warnings.
>
> I was thinking to send those after the merge window (so that I can route 
> through subsys maintainers and not bother Thomas, as they touch many 
> files [1]), but I will send them when I am back from a conf.

Ok. As far as I can tell, my two patches (mfd and pci) touching
four of those files are sufficient to address all the warnings
I see on x86, arm64 and arm. I came to the same conclusion about
being able to do more as cleanups but not needing them before the
merge window.

I also checked the power and mips specific files in your list
and they should be warning-free as far as I can tell.

       Arnd