Message-ID: <20250522092824.421e766c@booty>
Date: Thu, 22 May 2025 09:28:24 +0200
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: Liu Ying <victor.liu@....com>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie
 <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Andrzej Hajda
 <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>,
 Robert Foss <rfoss@...nel.org>, Laurent Pinchart
 <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>,
 Jernej Skrabec <jernej.skrabec@...il.com>, Jagan Teki
 <jagan@...rulasolutions.com>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
 <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Douglas Anderson
 <dianders@...omium.org>, Chun-Kuang Hu <chunkuang.hu@...nel.org>, Krzysztof
 Kozlowski <krzk@...nel.org>, Anusha Srivatsa <asrivats@...hat.com>, Paul
 Kocialkowski <paulk@...-base.io>, Dmitry Baryshkov <lumag@...nel.org>, Hui
 Pu <Hui.Pu@...ealthcare.com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, dri-devel@...ts.freedesktop.org,
 asahi@...ts.linux.dev, linux-kernel@...r.kernel.org,
 chrome-platform@...ts.linux.dev, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 linux-amlogic@...ts.infradead.org, linux-renesas-soc@...r.kernel.org,
 platform-driver-x86@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org,
 linux-stm32@...md-mailman.stormreply.com, Louis Chauvet
 <louis.chauvet@...tlin.com>, Alim Akhtar <alim.akhtar@...sung.com>, Inki
 Dae <inki.dae@...sung.com>, Kyungmin Park <kyungmin.park@...sung.com>,
 Seung-Woo Kim <sw0312.kim@...sung.com>, Manikandan Muralidharan
 <manikandan.m@...rochip.com>, Adam Ford <aford173@...il.com>, Adrien
 Grassein <adrien.grassein@...il.com>, Aleksandr Mishin
 <amishin@...rgos.ru>, Andy Yan <andy.yan@...k-chips.com>, AngeloGioacchino
 Del Regno <angelogioacchino.delregno@...labora.com>, Benson Leung
 <bleung@...omium.org>, Biju Das <biju.das.jz@...renesas.com>, Christoph
 Fritz <chf.fritz@...glemail.com>, Cristian Ciocaltea
 <cristian.ciocaltea@...labora.com>, Detlev Casanova
 <detlev.casanova@...labora.com>, Dharma Balasubiramani
 <dharma.b@...rochip.com>, Guenter Roeck <groeck@...omium.org>, Heiko
 Stuebner <heiko@...ech.de>, Jani Nikula <jani.nikula@...el.com>, Janne
 Grunau <j@...nau.net>, Jerome Brunet <jbrunet@...libre.com>, Jesse Van
 Gavere <jesseevg@...il.com>, Kevin Hilman <khilman@...libre.com>, Kieran
 Bingham <kieran.bingham+renesas@...asonboard.com>, Martin Blumenstingl
 <martin.blumenstingl@...glemail.com>, Matthias Brugger
 <matthias.bgg@...il.com>, Philipp Zabel <p.zabel@...gutronix.de>, Phong LE
 <ple@...libre.com>, Sasha Finkelstein <fnkl.kernel@...il.com>, Sugar Zhang
 <sugar.zhang@...k-chips.com>, Sui Jingfeng <sui.jingfeng@...ux.dev>, Tomi
 Valkeinen <tomi.valkeinen+renesas@...asonboard.com>, Vitalii Mordan
 <mordan@...ras.ru>, "Rob Herring (Arm)" <robh@...nel.org>, Hsin-Te Yuan
 <yuanhsinte@...omium.org>, Pin-yen Lin <treapking@...omium.org>, Xin Ji
 <xji@...logixsemi.com>, Aradhya Bhatia <a-bhatia1@...com>, Tomi Valkeinen
 <tomi.valkeinen@...asonboard.com>, Ian Ray <ian.ray@...ealthcare.com>,
 Martyn Welch <martyn.welch@...labora.co.uk>, Peter Senna Tschudin
 <peter.senna@...il.com>, Helge Deller <deller@....de>, Kuninori Morimoto
 <kuninori.morimoto.gx@...esas.com>, Laurent Pinchart
 <laurent.pinchart+renesas@...asonboard.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Philippe Cornu <philippe.cornu@...s.st.com>,
 Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>, Yannick Fertre
 <yannick.fertre@...s.st.com>, Alain Volmat <alain.volmat@...s.st.com>,
 Raphael Gallais-Pou <rgallaispou@...il.com>, Michal Simek
 <michal.simek@....com>, Jonathan Corbet <corbet@....net>,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 00/22] drm: convert all bridges to
 devm_drm_bridge_alloc()

Hello Liu,

On Thu, 22 May 2025 11:20:17 +0800
Liu Ying <victor.liu@....com> wrote:

> > If not, can we at least add a band-aid 'X:' entry for
> > drivers/gpu/drm/bridge/imx?
> > 
> > I think the other matching entry is the one to consider:
> > 
> > DRM DRIVERS FOR FREESCALE IMX BRIDGE
> > M:	Liu Ying <victor.liu@....com>
> > L:	dri-devel@...ts.freedesktop.org
> > S:	Maintained
> > F:	Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml
> > F:	Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-combiner.yaml
> > F:	Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml
> > F:	Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml
> > F:	drivers/gpu/drm/bridge/imx/
> > 
> > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L7940-7948)
> > 
> > However it does not list any trees. I _guess_ drm-misc applies here as
> > a fallback as well as common sense.
> > 
> > Liu, should this entry have a 'T:' line for drm/misc?  
> 
> These bridge drivers also don't have a 'T:' line:
> 
> DRM DRIVER FOR CHIPONE ICN6211 MIPI-DSI to RGB CONVERTER BRIDGE
> DRM DRIVER FOR PARADE PS8640 BRIDGE CHIP
> DRM DRIVER FOR TI DLPC3433 MIPI DSI TO DMD BRIDGE
> DRM DRIVER FOR TI SN65DSI86 BRIDGE CHIP
> LONTIUM LT8912B MIPI TO HDMI BRIDGE
> MEGACHIPS STDPXXXX-GE-B850V3-FW LVDS/DP++ BRIDGES
> MICROCHIP SAM9x7-COMPATIBLE LVDS CONTROLLER
> 
> I think that they fallback to drm-misc since "DRM DRIVERS FOR BRIDGE CHIPS"
> covers them.  I don't have strong opinion on adding a "T" line to them, at
> least to "DRM DRIVERS FOR FREESCALE IMX BRIDGE".  Anyway, it would be good
> to know comments from maintainers for "DRM DRIVERS FOR BRIDGE CHIPS" and
> "DRM DRIVERS".

I agree the fallback seems OK for this MAINTAINERS entry.

The other entry (ARM/FREESCALE IMX / MXC ARM ARCHITECTURE) is another
story.

> >>       drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API  
> > 
> > Not acked/reviewed, some discussion happened. I am resending it in v4,
> > possibly with updates based on the discussion.  
> 
> I still think the main structures in imx8qxp-pixel-combiner.c and imx*-ldb.c
> should have the same lifetime with the allocated bridges.  I added a new
> comment on this driver in v2 just now.

Thanks, let's continue the conversation there.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Powered by blists - more mailing lists