linux-kernel - Re: [PATCH v2] firmware: arm_scmi: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5edf74a6-7d01-4e1f-8d85-1be879d48700@kernel.org>
Date: Thu, 22 May 2025 10:41:37 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: long.yunjian@....com.cn, sudeep.holla@....com
Cc: cristian.marussi@....com, peng.fan@....com,
 florian.fainelli@...adcom.com, fang.yumeng@....com.cn,
 arm-scmi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, dan.carpenter@...aro.org,
 christophe.jaillet@...adoo.fr, mou.yi@....com.cn, ouyang.maochun@....com.cn,
 xu.lifeng1@....com.cn
Subject: Re: [PATCH v2] firmware: arm_scmi: Use dev_err_probe() simplify the
 code

On 21/05/2025 10:14, long.yunjian@....com.cn wrote:
> From: Yumeng Fang <fang.yumeng@....com.cn>
> 
> In the probe path, dev_err() can be replaced with dev_err_probe()

That's mailbox channel setup, not probe path.

Either this patch is wrong or commit msg is just not relevant.


> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs.

You explain the basic stuff, we all know it, but you miss to explain
things which we do not know. Rewrite your commit msgs to explain the
non-obvious.

We all know how dev_err_probe works. What we do not know is ALWAYS that
chan setup is the probe path (so prove that it is ALWAYS probe path).



Best regards,
Krzysztof